-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVE-1683-move separator #975
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 59c625a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 43.83% // Head: 47.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #975 +/- ##
===========================================
+ Coverage 43.83% 47.83% +3.99%
===========================================
Files 609 620 +11
Lines 25501 27734 +2233
Branches 6947 7156 +209
===========================================
+ Hits 11179 13267 +2088
- Misses 14276 14409 +133
- Partials 46 58 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
@henrily-ledger Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
/generate-screenshots |
While I'm ok with the code change, there's something wrong with the generated screenshots. There's no reason why this change in the operation details should have an impact on so many unrelated screenshots throughout the app. Can you check please @henrily-ledger |
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
changelog update screenshots (ubuntu-latest) Revert "update screenshots (ubuntu-latest)" This reverts commit afb49dcea69151a00506e5b6861a1877280dacbd.
6e9ae01
to
59c625a
Compare
@juan-cortes sorry I was vacation, so it's seems to be fine without generate screenshot ! |
changelog update screenshots (ubuntu-latest) Revert "update screenshots (ubuntu-latest)" This reverts commit afb49dcea69151a00506e5b6861a1877280dacbd.
π Description
We move the divider at the end to avoid the effect of an empty divider because of the operation details
β Context
live-desktop
https://ledgerhq.atlassian.net/browse/LIVE-1683
β Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.