Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-1683-move separator #975

Merged
merged 1 commit into from
Sep 19, 2022
Merged

LIVE-1683-move separator #975

merged 1 commit into from
Sep 19, 2022

Conversation

henri-ly
Copy link
Contributor

πŸ“ Description

We move the divider at the end to avoid the effect of an empty divider because of the operation details

❓ Context

  • Impacted projects: live-desktop
  • Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-1683

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

Screenshot 2022-08-18 at 15 32 20

Screenshot 2022-08-18 at 15 32 29

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 18, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 16, 2022 at 9:39AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 16, 2022 at 9:39AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 16, 2022 at 9:39AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 16, 2022 at 9:39AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022

πŸ¦‹ Changeset detected

Latest commit: 59c625a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the desktop Has changes in LLD label Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Base: 43.83% // Head: 47.83% // Increases project coverage by +3.99% πŸŽ‰

Coverage data is based on head (e4344ae) compared to base (343e444).
Patch has no changes to coverable lines.

❗ Current head e4344ae differs from pull request most recent head 59c625a. Consider uploading reports for the commit 59c625a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #975      +/-   ##
===========================================
+ Coverage    43.83%   47.83%   +3.99%     
===========================================
  Files          609      620      +11     
  Lines        25501    27734    +2233     
  Branches      6947     7156     +209     
===========================================
+ Hits         11179    13267    +2088     
- Misses       14276    14409     +133     
- Partials        46       58      +12     
Flag Coverage Ξ”
test 47.83% <ΓΈ> (+3.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...dger-live-common/src/families/cosmos/validators.ts 13.22% <0.00%> (-86.78%) ⬇️
...live-common/src/exchange/swap/joinSwapHistories.ts 7.69% <0.00%> (-61.54%) ⬇️
...s/ledger-live-common/src/account/importAccounts.ts 16.32% <0.00%> (-54.56%) ⬇️
...dger-live-common/src/exchange/swap/getProviders.ts 50.00% <0.00%> (-45.84%) ⬇️
libs/ledger-live-common/src/platform/converters.ts 35.71% <0.00%> (-14.29%) ⬇️
libs/ledger-live-common/src/transaction/common.ts 46.93% <0.00%> (-8.17%) ⬇️
libs/ledger-live-common/src/bridge/jsHelpers.ts 34.12% <0.00%> (-4.74%) ⬇️
...mon/src/families/cosmos/js-getTransactionStatus.ts 8.63% <0.00%> (-4.62%) ⬇️
libs/ledger-live-common/src/account/support.ts 42.30% <0.00%> (-3.85%) ⬇️
...ibs/ledger-live-common/src/hw/signMessage/index.ts 27.69% <0.00%> (-3.20%) ⬇️
... and 198 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Aug 18, 2022

@henrily-ledger

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@henri-ly
Copy link
Contributor Author

/generate-screenshots

@juan-cortes
Copy link
Contributor

While I'm ok with the code change, there's something wrong with the generated screenshots. There's no reason why this change in the operation details should have an impact on so many unrelated screenshots throughout the app. Can you check please @henrily-ledger

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Sep 4, 2022
@github-actions github-actions bot closed this Sep 11, 2022
@desirendr desirendr reopened this Sep 14, 2022
@github-actions github-actions bot added the screenshots Screenshots have been updated label Sep 14, 2022
changelog

update screenshots (ubuntu-latest)

Revert "update screenshots (ubuntu-latest)"

This reverts commit afb49dcea69151a00506e5b6861a1877280dacbd.
@henri-ly
Copy link
Contributor Author

@juan-cortes sorry I was vacation, so it's seems to be fine without generate screenshot !

@github-actions github-actions bot removed the Stale label Sep 17, 2022
@henri-ly henri-ly merged commit db69b7f into develop Sep 19, 2022
@henri-ly henri-ly deleted the bugfix/LIVE-1683-move-divider branch September 19, 2022 07:42
grsoares21 pushed a commit that referenced this pull request Sep 19, 2022
changelog

update screenshots (ubuntu-latest)

Revert "update screenshots (ubuntu-latest)"

This reverts commit afb49dcea69151a00506e5b6861a1877280dacbd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants