New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructuration - Initial draft #11

Open

popy-dev wants to merge 2 commits into Lewiscowles1986:master from popy-dev:restructuration

popy-dev commented Feb 18, 2018

Moved Node classes in a separate sub-directory
Defined an EncoderInterface and a Legacy implementation (relying on the untouched methods)
FormBody factory methods moved into Envelope for the sake of ease to use.
Added Manager class which basically replicates what the FormBody class did priori to some recent updates.
Removed the FormBody usage in tests
Added tests

See #4

popy-dev added 2 commits

February 18, 2018 22:20


          Started restructuration

b7f298e


          Added dependencies, fixed few issues, and added a test

efbe159

Owner

Lewiscowles1986 commented Feb 19, 2018

Thanks, I'm going to try to look more fully later today. I really appreciate outside input on this, and it's not like anyone is using it so 👍 there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet