New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructuration - Encoders draft #12

Open

popy-dev wants to merge 3 commits into Lewiscowles1986:master from popy-dev:encoders

popy-dev commented Feb 19, 2018

Added or updated some getters in NodeInterface implementations
Added Per-node encoders
Replicated node's __toString logic into encoders

See #4

Notes :

Still relies (too) heavily on current Node internals
Nodes __toString method could now be removed (but has been kept in order to minimize modifications in tests)
I'll have to find a solution to the Envelope's type problem, either by changing the EncoderInterface, or to split Envelope into 2 different Node containers (Root & FileGroup)

popy-dev added 3 commits

February 18, 2018 22:20


          Started restructuration

b7f298e


          Added dependencies, fixed few issues, and added a test

efbe159


          [Encoder] Added per-node-class basic encoders and updated tests

1fc0e43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet