fix: check combined outputs for potential errors when getting bacalhau job id #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
These changes check the combined output from
bacalhau create --id-only --wait path/to/job/spec
for errors because I noticed that sometimes when theid
was returned, the rest of the output also contained an error and the code was not checking for it, the rest of the process would execute but there would be no results in the output folder.How to test this code? (optional)
I don't think I have a straightforward way to reproduce the error, I noticed the situation when testing this PR, I added a print statement to the
runOutput
var and I noticed the full output also included info to the lines ofcould not execute job, not enough nodes
(I'm writing this from memory so if you are testing this bear in mind it may be a bit different) and the whole cli run was executed but the output folder did not include any files.With these changes the process did return an error in that situation and the RP console showed the error had happened.