fix: pow issue #214
fix: pow issue #214
Conversation
| runOutput := splitOutputs[len(splitOutputs)-1] | ||
| outputError := strings.Join(strings.Fields(strings.Join(splitOutputs[:len(splitOutputs)-1], " ")), " ") |
There was a problem hiding this comment.
Why are you removing this output? We cannot just silently disregard a potential error message in the combined output
There was a problem hiding this comment.
the id command ouput
udp buf size error log
result json.
this code not work.
maybe we can check by line number,if lines more than one. give a warn log. do you think it okay?
There was a problem hiding this comment.
How can we fix the udp buf size error?
There was a problem hiding this comment.
udp buf eeror occur in bacalau id command. i dont know how to fix.
maybe change some system config can fix that.
There was a problem hiding this comment.
Alright, capture the id, disregard the rest.
There was a problem hiding this comment.
for the udp buffer error, this is from bacalhau document:
While executing this command, you may encounter warnings regarding receive and send buffer sizes: failed to sufficiently increase receive buffer size. These warnings can arise due to limitations in the UDP buffer used by Bacalhau to process tasks. Additional information can be found in https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes.
I tested it and it works!
There was a problem hiding this comment.
I tested this too and it seems to work.
I think it's ok to discard the error output here because Bacalhau seems to be including irrelevant error output in the id command output. That's weird behavior.
There was a problem hiding this comment.
i think we should change to use rpc instead of subprocess command.
| runOutput := splitOutputs[len(splitOutputs)-1] | ||
| outputError := strings.Join(strings.Fields(strings.Join(splitOutputs[:len(splitOutputs)-1], " ")), " ") |
There was a problem hiding this comment.
I tested this too and it seems to work.
I think it's ok to discard the error output here because Bacalhau seems to be including irrelevant error output in the id command output. That's weird behavior.
Review Type Requested (choose one):
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Closes: add_link_here
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)