Mooring module #235
Mooring module #235
Conversation
|
@ssolson @rpauly18 I think a first pass at the mooring IO module is complete at this point. It's one function but it can ingest both the input and output files from Moordyn. There is still room for refinement and added functionality, but I need to find more complicated example output files than what's currently available to me. I'm working on a couple of simple functions that then utilize the output data to do some calculations and plotting. At this point, my question is, should we try to squeeze these extra functions into this PR or should we separate them into a later PR? What are your thoughts? |
|
@hivanov-nrel keep working off of this PR so we can have a complete example to work from on the review. |
|
@hivanov-nrel I agree that this looks like a good start. We will figure out who has time to tackle this review and make a formal assignment. Thanks! |
There was a problem hiding this comment.
@hivanov-nrel thanks for getting this started. I have made some general comments on this first function. Could you propagate these suggestions through the PR?
|
@ssolson Sorry for the holdup; i just pushed a commit that addresses your comments. Please let me know if there is anything else we need. Have you gone through the example notebook? |
Thanks @hivanov-nrel . My last comments were simply a quick check to knock out some easy fixes. I am going to take a deeper look today. I will go run the example notebook now. |
|
@hivanov-nrel some suggested updates are in a PR on your fork |
Mooring Example Notebook and Latested Development Branch
|
@ssolson thanks for your suggestions. I've approved the PR and merged into my fork. Let me know if there any other changes we need to make to this PR before merging to the dev branch |
There was a problem hiding this comment.
Chris checkout my PR hivanov-nrel#7 for my needed changes.
I just have 1 question below and the issue opened and I we are good to go on this PR.
Proposed Module Changes
**MHKiT 0.7.0 Release Notes** This release introduces exciting new features and improvements to the MHKiT package: - **Mooring Module**: We are pleased to introduce the new mooring module. This addition primarily supports outputs from MoorDyn. Within this module, users can: - Import data - Calculate lay length - Visualize mooring line movements in 2D and 3D with graphical animations. Accompanying this module is an example notebook to guide users on its functionalities. - **Dolfyn Module Revamp**: The Dolfyn module has been overhauled. Enhancements include: - Turbulence calculation capability - Performance measures for tidal power as outlined in IEC/TS 6200-200. - **New Contributions**: A big shoutout to our community member, @mbruggs, for adding the ability to compute surface elevation using IFFT. - **NDBC Buoy Metadata**: Users can now fetch NDBC buoy metadata directly through MHKiT. - **Delft3D Module Update**: Stay up to date with support for the latest Delft3D NetCDF format. **Additions** - #235 - #232 - #236 - #250 - #239 - #248 **Bug Fixes** - #226 - #238 **Meta/Minor Changes** - #220 - #243 - #225 - #231 - #224 Thank you to all of the contributers who helpped with this release: @mbruggs @Graham-EGI @castillocesar @jmcvey3 @hivanov-nrel @browniea @cmichelenstrofer @akeeste @maxwelllevin @rpauly18 @ssolson
Mooring module
create functions for mooring module:
Tests created for