Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MHKiT-MATLAB v0.5.0 Updates #73

Merged
merged 16 commits into from
Aug 8, 2024

Conversation

simmsa
Copy link
Contributor

@simmsa simmsa commented Jul 31, 2024

This PR includes the following from MHKiT-MATLAB v.05.0:

  • Updated MHKiT-MATLAB submodule

  • New Livescripts:

    • Delft 3D Livescript
    • WDRT Livescripts
  • API Documentation

    • DOLfYN
  • Installation

    • Update screenshots
    • Downgrade pip versions where necessary:
      • pip install numpy~=1.24.0 scipy~=1.10.0 netcdf4~=1.6.0

Other changes:

@simmsa simmsa marked this pull request as ready for review August 1, 2024 17:30
@simmsa simmsa marked this pull request as draft August 1, 2024 17:41
@simmsa simmsa requested a review from akeeste August 1, 2024 17:55
@simmsa
Copy link
Contributor Author

simmsa commented Aug 1, 2024

@akeeste this is mostly good go, but before merging I would like to get your opinion on #74. After make clean && make html I just added all of the changed files and 2 of the larger ones caused the warning in #74. The commit history has these large files right now, but I can fix that with a force push. Long term it would be nice to not have huge (unnecessary?) files in the commit history, but in the short term this is working. I could fix #74 in this PR and avoid having these two large files.

Per https://stackoverflow.com/questions/33904042/is-doctrees-folder-required-for-displaying-html-docs-with-sphinx

doctrees contains a cache of rst source docs and are not needed in the
repository.

These files are getting large enough to trigger warnings during git
push:

```
File docs/doctrees/mooring_example. doctree is 58.16 MB; this is larger than GitHub's recommended maximum file size of 50.00 MB
```

To mitigate this warning and further errors we are ignoring the
`docs/doctree` and the older `docs/.doctree` folders.
This is not needed to display html.

`docs/.doctrees` seems to be an artifact from an ~4 year old build of
the mhkit documentation. This folder is dynamically created during a
build and is not necessary to save to the commit history.
Per https://stackoverflow.com/questions/33904042/is-doctrees-folder-required-for-displaying-html-docs-with-sphinx

doctrees contains a cache of rst source docs and are not needed in the
repository.

These files are getting large enough to trigger warnings during git
push:

```
File docs/doctrees/mooring_example. doctree is 58.16 MB; this is larger than GitHub's recommended maximum file size of 50.00 MB
```

To mitigate this warning and further errors we are ignoring the
`docs/doctree` and the older `docs/.doctree` folders.
@simmsa simmsa marked this pull request as ready for review August 5, 2024 16:06
@simmsa
Copy link
Contributor Author

simmsa commented Aug 5, 2024

@akeeste, this is good to go now. The initial comment is up to date and includes all of the changes. Ignoring and removing docs/doctrees fixed the LFS warning detailed in #74. Let me know if you see anything else...

@simmsa simmsa merged commit 01904ef into MHKiT-Software:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant