Refactored how location of the game is aquired to a simpler version. #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Understating how FF8Dir is created
Basic information
FF8Dir
is a variable which stores root directory of Final Fantasy 8 game.Depends on the OS, different strategy will be used to get that root directory. Now, there are two supported OSes: Windows and Linux.
Windows take on finding root directory
Algorithm first checks, if GameLocation is in array of hardcoded paths defined in
HardcodedGameLocationProvider
. If that is not the case, game checks into registers to find game location.If game location wasn't found in also registers, game throws
DirectoryNotFoundException
.Linux take on finding root directory
In case of Linux, game just check for hardcoded paths using
HardcodedGameLocationProvider
. If game location wasn't found throwsDirectoryNotFoundException
.Metrics
To find a path to the game game uses following classes:
Number of lines in these classes:
In total of 199 lines of code.
I think I can make it simpler.