-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including declarations in your npm package #181
base: master
Are you sure you want to change the base?
Conversation
package.json
Outdated
"@types/rimraf": "^3.0.0", | ||
"@types/semver": "^7.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving these shouldn't be required, the types of these packages are not re-exported as part of our defs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarshallOfSound I guess you right
@MarshallOfSound Do you think you could merge this? There's no up-to-date types available at |
Declaration files are already created. I only added certain changes to the
package.json
, following TypeScript documentation.