WIP module load, and builtin create once #635
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
force-pushed
the
create-system_builtin-once
branch
from
880605f
to
b4ceab7
Compare
rocky
force-pushed
the
create-builtin-system_init
branch
from
9c21740
to
da8580c
Compare
rocky
force-pushed
the
create-system_builtin-once
branch
2 times, most recently
from
d8eeb84
to
6436065
Compare
rocky
force-pushed
the
create-builtin-system_init
branch
from
da8580c
to
3a10131
Compare
This isn't working but this is the idea. Another PR will contain some of the independent bugs found in this process
rocky
force-pushed
the
create-system_builtin-once
branch
from
6436065
to
7fee71c
Compare
rocky
changed the title
rocky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be closed soon See #648
That PR tries to do that as well as move code out of the
Defintionsobject creation.In has become apparent that it is too much work to try to do both things in one PR. So this and the follow-on PRs that are based on this need to be reworked.
@mmatera This doesn't work, but it's closer to the idea.
What I am seeing pytests are not working, e.g.
test/format/test_{asy,format,svg}.pyandtest/builtin/test_comparison.pyIf you can get it to work great. If not, I will narrow the difference next weekend. Many of the bugs so far have been imports pointing to the old (
mathics.builtin) location.However, format problems, I think have to do with some sort of magic that occurs that is noted in master when the definitions object does an
import mathics.format