Ignore import diagnostics in certain filetypes

Matsuuu · Nov 8, 2023 · a77dc96 · a77dc96
1 parent 5696774
commit a77dc96
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/lib/server/src/diagnostics.ts b/lib/server/src/diagnostics.ts
@@ -14,18 +14,31 @@ const DISABLE_FLAGS = {
     DISABLE_IMPORT_CHECK: "cels-disable-import-check"
 }
 
+const DEFAULT_DISABLE_IMPORT_CHECKS_FILETYPES = ["md", "html", "php"];
+
 export async function runDiagnostics(uri: string, textDoc: TextDocument) {
     handleDiagnostics(uri, textDoc);
 }
 
+function shouldIgnoreImportDiagnostics(fileName: string) {
+    const fileExtension = fileName.split(".").at(-1) ?? "__CELS_NO_ENDING";
+    if (DEFAULT_DISABLE_IMPORT_CHECKS_FILETYPES.includes(fileExtension)) {
+        return true;
+    }
+    if (!fileName.endsWith(fileExtension)) {
+        return true;
+    }
+
+    return false;
+}
+
 function handleDiagnostics(uri: string, textDoc: TextDocument) {
     const fileName = url.fileURLToPath(uri);
     const usableData = textDocumentToUsableData(textDoc);
     const queryData = generateLanguageServiceQueryDataForDiagnostics(usableData, textDoc.uri);
     const text = textDoc.getText();
     const disableDiagnostics = text.includes(DISABLE_FLAGS.DISABLE_ALL);
 
-
     if (disableDiagnostics) {
         connection.sendDiagnostics({ uri: textDoc.uri, diagnostics: [] });
         return;
@@ -42,7 +55,7 @@ function handleDiagnostics(uri: string, textDoc: TextDocument) {
     if (!text.includes(DISABLE_FLAGS.DISABLE_MISSING_CLOSED)) {
         diagnostics = [...diagnostics, ...getMissingCloseTagDiagnostics(request)];
     }
-    if (!text.includes(DISABLE_FLAGS.DISABLE_IMPORT_CHECK)) {
+    if (!text.includes(DISABLE_FLAGS.DISABLE_IMPORT_CHECK) && !shouldIgnoreImportDiagnostics(fileName)) {
         diagnostics = [...diagnostics, ...getImportDiagnostics(request)];
     }
 

diff --git a/usage-testing-project/src/card.astro b/usage-testing-project/src/card.astro
@@ -1,5 +1,4 @@
 ---
-import "./example-project.js";
 interface Props {
   title: string;
   body: string;

diff --git a/usage-testing-project/src/index.php b/usage-testing-project/src/index.php
@@ -3,6 +3,6 @@
 ?>
 
 <div>
-  <sl-button variant=""></sl-button>
+  <sl-button variant="">
 
 </div>