null pointer for empty content files mentioned in [TOC]

MaxMelcher · Jan 24, 2022 · 1ae131e · 1ae131e
1 parent e62b13b
commit 1ae131e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -14,11 +14,11 @@
                 "--verbose",
                 //"-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\DeepLink",
                 "-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\AzureDevOps.WikiPDFExport.wiki",
-                //                "--attachments-path=..\\AzureDevOps.WikiPDFExport.Test\\Tests\\AzureDevOps.WikiPDFExport.wiki\\.attachments\\",
-                //               "-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\Code",
-                //                "-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\Azure-Platform-Design",
-                //                "-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\1k",
-                //                "-s..\\AzureDevOps.WikiPDFExport.Test\\Tests\\Test-Emoticon\\emoji.md",
+                //                 "--attachments-path=..\\AzureDevOps.WikiPDFExport.Test\\Tests\\AzureDevOps.WikiPDFExport.wiki\\.attachments\\",
+                //                 "-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\Code",
+                //                 "-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\Azure-Platform-Design",
+                //                 "-p..\\AzureDevOps.WikiPDFExport.Test\\Tests\\1k",
+                //                 "-s..\\AzureDevOps.WikiPDFExport.Test\\Tests\\Test-Emoticon\\emoji.md",
                 "--heading",
                 "--breakPage",
                 //              "-m",

diff --git a/AzureDevOps.WikiPDFExport/WikiPDFExporter.cs b/AzureDevOps.WikiPDFExport/WikiPDFExporter.cs
@@ -407,8 +407,10 @@ private string ConvertMarkdownToHTML(List<MarkdownFile> files)
             pipelineBuilder.Extensions.RemoveAll(x => x is Markdig.Extensions.AutoIdentifiers.AutoIdentifierExtension);
             //handled by katex
             pipelineBuilder.Extensions.RemoveAll(x => x is Markdig.Extensions.Mathematics.MathExtension);
+
+            //todo: is this needed? it will stop support of resizing images:
             //this interferes with katex parsing of {} elements.
-            pipelineBuilder.Extensions.RemoveAll(x => x is Markdig.Extensions.GenericAttributes.GenericAttributesExtension);
+            //pipelineBuilder.Extensions.RemoveAll(x => x is Markdig.Extensions.GenericAttributes.GenericAttributesExtension);
 
             DeepLinkExtension deeplink = new DeepLinkExtension();
             pipelineBuilder.Extensions.Add(deeplink);
@@ -461,6 +463,10 @@ private string ConvertMarkdownToHTML(List<MarkdownFile> files)
 
                 var md = mf.Content;
 
+                if (string.IsNullOrEmpty(md)) { 
+                    Log($"File {file.FullName} is empty and will be skipped!", LogLevel.Warning, 1);
+                    continue;}
+
                 //rename TOC tags to fit to MarkdigToc or delete them from each markdown document
                 var newTOCString = _options.GlobalTOC != null ? "" : "[TOC]"; 
                 md = md.Replace("[[_TOC_]]", newTOCString);

diff --git a/AzureDevOps.WikiPDFExport/export.pdf b/AzureDevOps.WikiPDFExport/export.pdf