Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body element missing from rendered HTML #122

Closed
Zhaph opened this issue Oct 7, 2022 · 0 comments · Fixed by #123
Closed

Body element missing from rendered HTML #122

Zhaph opened this issue Oct 7, 2022 · 0 comments · Fixed by #123

Comments

@Zhaph
Copy link
Contributor

Zhaph commented Oct 7, 2022

Possibly related to #114 I found that I was unable to apply a global style to the output as there was no <body> element in the mark up.

Suggest updating the generated HTML to:

//build the html for rendering
html = $"{htmlStart}{headStart}{string.Concat(header)}{headEnd}<body>{html}<footer>{string.Concat(footer)}</footer></body>{htmlEnd}";
Zhaph added a commit to Zhaph/AzureDevOps.WikiPDFExport that referenced this issue Oct 7, 2022
@Zhaph
MaxMelcher#122 Add body element to HTML
8f33976
Zhaph added a commit to Zhaph/AzureDevOps.WikiPDFExport that referenced this issue Oct 7, 2022
@Zhaph
MaxMelcher#122 Added Body element around html body
6adb97d
@Zhaph Zhaph mentioned this issue Oct 7, 2022
Merged
MaxMelcher pushed a commit that referenced this issue Oct 10, 2022
@Zhaph @MaxMelcher
#122 Added Body element around html body
7a5ab99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#122 Added Body element around html body Zhaph/AzureDevOps.WikiPDFExport
1 participant
@Zhaph