Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #97 - Internal Links and TOC updates #98

Merged
merged 7 commits into from
Feb 24, 2022
Merged

Conversation

Diom
Copy link
Contributor

@Diom Diom commented Feb 22, 2022

TOC:

  • Add a class to allow for page breaking
  • Fixes for ~ fenced code blocks to be supported

Internal Links:

  • Detects the base folder by finding the .attachements directory
  • Allows for "code-wikis" to work with internal links
  • Fixes minor issue with ':' character not working because of inconsistent URL escaping

Dennis Laffey added 2 commits February 22, 2022 11:42
* Add a new class which resolves directory facts
  about the export
* Added changes to support ':' chars in titles
* TOC container class added to allow styling
Log($"Reading .order file in directory {exportBase}");
var orderFiles = directory.GetFiles(".order", SearchOption.TopDirectoryOnly);
return Path.GetFullPath("ds");
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this

@Diom
Copy link
Contributor Author

Diom commented Feb 24, 2022

@MaxMelcher Hey Max, wasn't sure about modifying the "code" example. Let me know if you have any concerns. I can add it a new wiki folder instead if you would prefer.

// Add URL replacements here
var replacements = new Dictionary<string, string>(){
{":", "%3A"},
{"#", "-"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%20 was missing - that happens if you have a space in your filename/picture.

@MaxMelcher
Copy link
Owner

@MaxMelcher Hey Max, wasn't sure about modifying the "code" example. Let me know if you have any concerns. I can add it a new wiki folder instead if you would prefer.

no worries. Adding stuff here increases the test coverage :)

@MaxMelcher MaxMelcher merged commit c3b24db into MaxMelcher:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants