Fix build issues with newer pytorch #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build issues are due to the deprecation of the THC lib, This migration is based on the suggestions from pytorch/pytorch#72807 (comment) The torch extension infra seems to enforce no_half_operators, this results in an issue with the atomicAdd function which does accept c10::Half The workaround is based on this discussion https://forums.developer.nvidia.com/t/atomicadd-not-overloaded-for-c10-half/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build issues are due to the deprecation of the THC lib,
This migration is based on the suggestions from
pytorch/pytorch#72807 (comment)
The torch extension infra seems to enforce no_half_operators, this results in an issue with the atomicAdd function which does accept c10::Half
The workaround is based on this discussion
https://forums.developer.nvidia.com/t/atomicadd-not-overloaded-for-c10-half/
Tested compiling on
pytorch/pytorch:1.13.1-cuda11.6-cudnn8-devel