Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Alternative name to reduce confusion #447

Closed
ariya opened this issue Jan 27, 2016 · 14 comments
Closed

Alternative name to reduce confusion #447

ariya opened this issue Jan 27, 2016 · 14 comments

Comments

@ariya
Copy link

ariya commented Jan 27, 2016

I apologize for reviving an old topic from > 3 years ago (see #10).

After all these years, we (=PhantomJS team) always have the need to explain in many different forms of conversation (Github issue, tweet, email, etc) that this npm-based package is an installer and not the actual PhantomJS itself. We would politely redirect them here to continue their issues with installation, troubleshooting, availability, or other inquiry.

Hence why I argued long time ago (in #10) that this confusion could be reduced by giving this project a different name, e.g. phantomjs-installer, instead of just the vanilla phantomjs. Back then, this thought was driven by my gut-feeling. Now we now that this confusion truly exists due to the repeated explanation we need to give.

In short: I think this project is great, giving easy access to Node.js developers to install PhantomJS. With a minor name tweak, I believe this will reduce confusion for everyone.

Thank you for your consideration!

@bedney
Copy link

bedney commented Jan 27, 2016

I concur with this, especially given the fact that the version numbers between the two can differ, which causes yet more confusion still. Even after using the 'npm PhantomJS installer' for 2+ years, I myself have to be overly precise about which I'm talking about when talking with others: the core PhantomJS or the npm installer.

Having said that, let me also offer my thanks to the team here - many people use this package as an easy way to install PhantomJS.

@nicks
Copy link
Contributor

nicks commented Jan 27, 2016

@ariya is phantomjs-prebuilt ok by you?

i'm skeptical -- my impression is that the confusion is less about the name, and more about the (incorrect) assumption that phantomjs-team controls and provides support for all phantomjs distribution channels.

but i'm fine with deprecating phantomjs and pointing people to phantomjs-prebuilt. worst-case it creates a lot of busy-work for people downstream who have to update their package references. We can always undeprecate if there's a revolt.

@ariya
Copy link
Author

ariya commented Jan 27, 2016

@nicks Your skepticism might be right, I just think that having the exact same name does not cause people to pause and think, and hence their assumption will not be corrected (ever).

I'm fine with any name, pick something that suits you well.

@bedney
Copy link

bedney commented Jan 27, 2016

Might I suggest node-phantomjs? It would be in keeping with how many other npm packages are named.

OTOH - this really isn't a NodeJS package per se...

Anyway, feel free to ignore this comment from the peanut gallery and thanks again to both of you guys for your work on these projects! 😄

@ariya
Copy link
Author

ariya commented Jan 27, 2016

Here is an interesting data point: since I filed this issue 11 hours, there have been two install problems that this project probably should be aware of:

@nicks
Copy link
Contributor

nicks commented Jan 27, 2016

i don't think ariya/phantomjs#12970 (comment) is referring to this package. we have never tried to install phantomjs 2.0.0. (i.e., people are complaining to you about lots of npm installer packages, not just this one)

@ariya
Copy link
Author

ariya commented Jan 27, 2016

@nicks I'm not implying that the report is valid. I just don't have enough information to immediately verify the claim (without going to this project, check that it never deals with 2.0.0, and so on).

@nicks
Copy link
Contributor

nicks commented Jan 27, 2016

@ariya We've agreed to change the name. Are you looking for some additional action?

There are many NPM phantomjs installers with many names. Bugs in them get reported to your repo. Bugs in them get reported to our repo. Not sure if that makes you feel any better. Users are crazy!

@ariya
Copy link
Author

ariya commented Jan 27, 2016

@nicks Thanks for your consideration and feel free to resolve this issue once an npm package with the new name is published.

@nicks
Copy link
Contributor

nicks commented Jan 28, 2016

https://www.npmjs.com/package/phantomjs shows a deprecation notice !

long live https://www.npmjs.com/package/phantomjs-prebuilt !!

@ariya
Copy link
Author

ariya commented Jan 28, 2016

👍

@bedney
Copy link

bedney commented Jan 28, 2016

Thank You 😃

joelmukuthu pushed a commit to joelmukuthu/phantom-render-stream that referenced this issue Jan 28, 2016
The package is now called 'phantomjs-prebuilt' on npm.
See Medium/phantomjs#447
@just-boris
Copy link

As I understand, there is no need to rename package on NPM.
The issue here that top packages have the same name: https://github.com/search?utf8=✓&q=phantomjs
The same thing with google search results.
People probably are confused and can get to the wrong project.

Rename project in NPM doesn't solve that issue at all because nothing changed in Github.

@jakub-g
Copy link

jakub-g commented Jan 28, 2016

Agreed with the last comment of @just-boris, probably you could also consider renaming the GitHub repo.

FYI when you rename a repo on GitHub, then GitHub will put a permanent HTTP-URL and git-URL redirections from old name to the name name, so all the bookmarks / links / git remotes people have will continue to work. So, it's pretty safe to change repo name on GitHub without any unwanted side-effects.

pocketjoso added a commit to pocketjoso/penthouse that referenced this issue Jan 28, 2016
Arkni added a commit to Arkni/grunt-lib-phantomjs that referenced this issue Feb 1, 2016
The npm package phantomjs is deprecated. The name was changed to
phantomjs-prebuilt per request of PhantomJS team (Medium/phantomjs#447).

Ref Medium/phantomjs#453
Closes gruntjs#97
joschi pushed a commit to Graylog2/graylog2-server that referenced this issue Feb 9, 2016
josephfrazier added a commit to josephfrazier/browser-extension that referenced this issue Jul 14, 2016
It was renamed to phantomjs-prebuilt, and karma-phantomjs-launcher now
installs it. See the following for details:

Medium/phantomjs#447 (reference)
karma-runner/karma-phantomjs-launcher#123
josephfrazier added a commit to OctoLinker/OctoLinker that referenced this issue Jul 14, 2016
I'm hoping this will fix the intermittent error described in #115 (comment)

* Upgrade phantomjs to ^2.1.7

* Upgrade karma-html2js-preprocessor to ^1.0.0

* Upgrade karma-mocha to ^1.1.1

* Upgrade karma-mocha-reporter to ^2.0.4

* Add missing peer dependency karma

* Upgrade karma-phantomjs-launcher to ^1.0.1

* Remove phantomjs from devDependencies

It was renamed to phantomjs-prebuilt, and karma-phantomjs-launcher now
installs it. See the following for details:

Medium/phantomjs#447 (reference)
karma-runner/karma-phantomjs-launcher#123
glepretre added a commit to glepretre/dotfiles that referenced this issue Aug 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants