Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several dependencies need updates in order to support iojs 2.x #73

Merged
merged 1 commit into from
Jul 15, 2015

Conversation

ddbenson
Copy link
Contributor

Hello @nicks, @xiao, @kylehg,

Please review the following commits I made in branch 'ddb-update-npm-deps'.

I'm not sure if I should up the version of this in package.json as well.

e322c87 (2015-07-14 21:00:02 -0700)
Several dependencies need updates in order to support iojs 2.x

R=@nicks
R=@xiao
R=@kylehg

@nicks
Copy link
Contributor

nicks commented Jul 15, 2015

lgtm

@nicks
Copy link
Contributor

nicks commented Jul 15, 2015

to answer your question: yes, you'll need to bump the main package version if you want to pull this into medium2

@ddbenson
Copy link
Contributor Author

Cool -- will update. How about publishing to npm.org?

@nicks
Copy link
Contributor

nicks commented Jul 15, 2015

you can either publish as the Medium npm account, or ping me on slack and I can publish it for you.

ddbenson added a commit that referenced this pull request Jul 15, 2015
Several dependencies need updates in order to support iojs 2.x
@ddbenson ddbenson merged commit d89789a into master Jul 15, 2015
@ddbenson ddbenson deleted the ddb-update-npm-deps branch July 15, 2015 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants