Tidy up package #37
Merged
Tidy up package #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukuhiro2023
reviewed
Aug 7, 2024
vignettes/base_char.rtf
Outdated
There was a problem hiding this comment.
Should this file be output in "vignettes/outtable" folder?
This is related to Line #261 of vignettes/baseline-character.Rmd.
fukuhiro2023
reviewed
Aug 7, 2024
| @@ -221,7 +205,7 @@ x <- outdata |> | |||
| format_disposition() | |||
|
|
|||
| x$tbl <- x$tbl %>% | |||
| mutate(name = ifelse(trimws(name) == "ZStatus Not Recorded", " Status Not Recorded", name)) | |||
| mutate(name = ifelse(trimws(name) == "Status Not Recorded", " Status Not Recorded", name)) | |||
There was a problem hiding this comment.
If this term is changed, the term in Line #77 also needs to be changed.
mutate(DCTREAS = ifelse(DISCONFL == "Y", DCREASCD, "ZStatus Not Recorded"))
fukuhiro2023
reviewed
Aug 7, 2024
vignettes/outtable/disposition.rtf
Outdated
There was a problem hiding this comment.
This sample may be confused since the reason for discontinuation is displayed even under "Completed" and "Participants Ongoing".
It would be more realistic as sample data to set a value of DCTREAS (and DCSREAS for study discontinuation) only when EOTSTT1 is "discontinued" because DCTREAS is a variable of reason for discontinuation of treatment.
fukuhiro2023
reviewed
Aug 7, 2024
fukuhiro2023
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up the package to pass build check and fix a bug