-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign flashtank #297
base: main
Are you sure you want to change the base?
Redesign flashtank #297
Conversation
Signed-off-by: pepmts <[email protected]>
Signed-off-by: pepmts <[email protected]>
Signed-off-by: pepmts <[email protected]>
I have some problems with this change :
@casella and @AndreaBartolini do you have an idea of what I should do to fix that ? |
Signed-off-by: pepmts <[email protected]>
Hi, I need some clarifications regarding the
Note that this is valid because the flow directions are fixed "at priori", otherwise the
|
When you use the stream connectors the stream variable shall be always assigned by the component that instantiate the connector, also if it is never used because the flow direction is fixed "at priori". |
@pepmts regarding the balancedness, For example, you could put a pump model on the liquid outlet, leave the rotational speed input unconnected (+1 d.o.f.) and add one equation to set |
Hello, sorry for the late response !
Agreed, I added it, @AndreaBartolini
I agree it is not, and that is my main concern, it should, since we should have Just to recall I did this new component because we had discussed a while ago on the fact that the FlashTank was not locally balanced, and you advised to create a component with only three connectors and no connections between them, but now it seems that I am back to the initial problem, though the model is much simpler. |
Signed-off-by: pepmts <[email protected]>
This is exactly the point. The My opinion is that the An additional note: Q_in` * inStream(C_in.h_outflow) + C_steam_out.Q * C_steam_out.h_outflow = C_liquid_out.Q * C_liquid_out.h_outflow; it seems to me that the term C_liquid_out.Q * C_liquid_out.h_outflow; should be placed in the left side of the balance... (both Q_in` * inStream(C_in.h_outflow) + C_steam_out.Q * C_steam_out.h_outflow + C_liquid_out.Q * C_liquid_out.h_outflow = 0; |
I completely agree on the second point, it was a mistake |
To me it seems really weird that this model is globally balanced (since it has no inputs nor connector inputs) but that we can specify |
Signed-off-by: pepmts <[email protected]>
the model is balanced because it has the same number of equations and variables (14) were:
equations are:
Q_in = C_in.Q;
P = C_in.P;
C_steam_out.P = P;
C_liquid_out.P = P;
h_vap_sat = WaterSteamMedium.dewEnthalpy(WaterSteamMedium.setSat_p(P));
h_liq_sat = WaterSteamMedium.bubbleEnthalpy(WaterSteamMedium.setSat_p(P));
C_in.h_outflow = 0;
C_steam_out.h_outflow = x_steam_out * h_vap_sat + (1-x_steam_out)*h_liq_sat;
C_liquid_out.h_outflow = h_liq_sat;
Q_in + C_steam_out.Q + C_liquid_out.Q = 0;
Q_in * inStream(C_in.h_outflow) + C_steam_out.Q * C_steam_out.h_outflow + C_liquid_out.Q * C_liquid_out.h_outflow = 0;
So the local model is balanced but the overall model has four degree of freedom between: By the same way you can in general prescribe four of the above listed degree of freedom and the overall model will calculate the fifth. |
BTW, you can prescribe the |
we will better discuss this matter in the next follow-up meeting |
The current state is that the Flash tank is really locally balanced but then the steam dryer is not, because we need to fix the |
Goal
Work to fix #113 by redesigning the flash tank, using a partial volume instead.
Type of change
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.