-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix power connectors again #419
Draft
pierre-eliep-met
wants to merge
11
commits into
main
Choose a base branch
from
fix-power-connectors-again
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pepmts <[email protected]>
Signed-off-by: pepmts <[email protected]>
Signed-off-by: pepmts <[email protected]>
Signed-off-by: pepmts <[email protected]>
I've just spotted a problem on compressor unit tests 😭 |
Signed-off-by: pepmts <[email protected]>
…v/metroscope-modeling-library into fix-power-connectors-again
Signed-off-by: pepmts <[email protected]>
Signed-off-by: pepmts <[email protected]>
Seems like it's working. However, it seems like a lot of work to be able to implement multi nodes with power connectors. It brings added complexity in understanding the library, with a lot of unused variables... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes #99 again, update of #278.
What was the problem ?
Power connectors were not balanced because :
W
Solution
dummy
potential variable in connectorsImplementation
dummy
variable is created in power inlet and outlet connectorsdummy
variable of power connectors is set as a connector inputdummy
of this connector, so I just added a power sink in the SG, and sincedummy=0
is defined in the sink, it defines it into the connection set there.Warnings
Note that this is a bit weird and not super flexible/robust because you could be willing to connect some power components that would both try to set the
dummy
variable, resulting in an over constrained model.But it shouldn't be a problem (as of now), because we should never face this issue, because we would probably never have a single connection set with several generators/power sensors/power sinks, etc.
Type of change
package.mo
)Will it break anything in previous models ?
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.