Cooling tower first model #472

phelimb-met · 2024-03-27T14:52:07Z

Goal

Describe the big picture of your changes here (one sentence).

If it fixes an issue, mention the issue using closing key words (how to do that ?), or in development section of your PR's information.

Type of change

Bugfix
New feature
Refactoring change
Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

Breaking change (If yes, make sure to point it out in the changelog)
Non-Breaking change

Checklist

I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
I have performed a self-review of my own code
I have checked that all existing tests pass.
I have added/updated tests that prove my development works and does not break anything.
I have made corresponding changes or additions to the documentation (in Notion documentation)
I have added corresponding entries to the Changelog
I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

hadrienp-met · 2024-04-04T15:14:08Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTower3.mo

So now the heat exchange is between the water source and water sink, so the component hot_side_cooling should be replace by an IsoPHFlowModel (at the moment it is an IsoPFlowModel )

hadrienp-met · 2024-04-04T15:15:47Z

MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/CoolingTower_reverse.mo

@@ -107,7 +107,7 @@ equation

  // Observable for Calibration
  WaterOutletTemp_sensor.T_degC = WaterOutletTemp;
-  AirOutletTemp_sensor.T_degC = AirOutletTemp;
+  AirOutletTemp_sensor.T_degC = AirOutletTemp-10*time;


Be careful to not forget *time in your model, it should be used only for testing

hadrienp-met · 2024-04-04T15:16:39Z

MetroscopeModelingLibrary/Tests/Multifluid/HeatExchangers/CoolingTower_reverse.mo

@@ -32,7 +32,7 @@ model CoolingTower_reverse
  output Real Q_cold(start=52552.133) "m3/s";

  output Real airOutletPress(start=1) "bar";
-  output Real AirOutletTemp(start=35) "deg_C";
+  input Real AirOutletTemp(start=35) "deg_C";                            //output


With the correction on the component (isoPH instead of isoP), you won't have anymore to impose this temperature

hadrienp-met · 2024-04-04T15:37:30Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTower3.mo

-  Water_outlet.T_out = Water_inlet.T_in;
-  Water_outlet.Q_out = Water_inlet.Q_in - Q_makeup;
+  //Water_outlet.T_out = Water_inlet.T_in;
+  Water_outlet.Q_out = Q_hot - Q_makeup;


Q_out it negative (flow going out a componenet is negative by convention, so here it should be :
Water_outlet.Q_out = - (Q_hot - Q_makeup);

I think it could be a could idea to create a new variable Q_hot_out and renaming Q_hot by Q_hot_in

hadrienp-met

Good job, with a lower air temperature the Hd should be positive. But we should keep this in mind because a CT is working even if the air is warmer than the water. Maybe that's a limit of our hypothesis.

hadrienp-met

Good job, I made some small test and the results looks good.

hadrienp-met · 2024-05-24T08:30:19Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

This file can be deleted now, we keep only the model with supersaturated air

hadrienp-met · 2024-05-24T08:30:44Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppewithSS.mo

Rename the file CoolingTowerPoppe

hadrienp-met · 2024-05-24T08:31:20Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppewithSS.mo

+  import MetroscopeModelingLibrary.Utilities.Media.WaterSteamMedium;
+  import MetroscopeModelingLibrary.Utilities.Media.MoistAirMedium.specificEnthalpy;
+
+  //Unsaturated Air


It could be useful to put in comment where does the equations come from

hadrienp-met · 2024-05-24T08:31:58Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppewithSS.mo

+  Inputs.InputReal hd;
+  Inputs.InputArea Afr;
+  Inputs.InputReal Lfi;
+  Inputs.InputFrictionCoefficient Cf;


Put in comment the full name of the parameters

hadrienp-met · 2024-05-24T08:32:56Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppewithSS.mo

+    // Poppe Inputs
+  Units.Temperature deltaTw;
+
+  parameter Integer N_step = 10;


This parameter should be at the top of the model and have a description

hadrienp-met · 2024-05-24T08:37:34Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppewithSS.mo

+  Lef[1] = 0.9077990913 * (((MoistAir.xsaturation_pT(Pin[1], T_cold_in)+0.622)/(w[1]+0.622))-1) / log((MoistAir.xsaturation_pT(Pin[1], T_cold_in)+0.622)/(w[1]+0.622));
+  cp[1] = WaterSteamMedium.specificHeatCapacityCp(water_inlet_flow.state_in);
+
+   // Drift Equation


This equation is correct only for natural draft cooling tower. I think we should also add the equation that describe the fans behaviour with an if condition to selected the configuration. Something like:

if configuration = "natural draft" then ... else ...

This has to be done also for the Merkel model.

hadrienp-met · 2024-05-24T08:42:13Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppewithSS.mo

+  Real Lef[N_step];
+  Units.MassFlowRate Qw[N_step];
+  Units.MassFlowRate Qa[N_step];
+


It would be interesting to add the estimation of the rejected heat in MW

hadrienp-met · 2024-06-24T13:11:36Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+    y:= cp / ((MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i + (Lef-1) * (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i - (MoistAir.xsaturation_pT(Pin, Tw) - MoistAir.xsaturation_pT(Pin, Ta)) * MoistAir.h_pTX(Pin, Tw, {1})) + (w - MoistAir.xsaturation_pT(Pin, Ta)) * cp * Tw) + (w - MoistAir.xsaturation_pT(Pin, Tw)) * cp * Tw);
+  end m;
+
+  Units.Velocity V_inlet;                             //Wind velocity entering cooling tower


Suggested change

Units.Velocity V_inlet; //Wind velocity entering cooling tower

Units.Velocity V_inlet; //Air velocity at the bottom of the cooling tower

hadrienp-met

I made a few comments to improve the CT components (mainly to make them clearer).
Also, don't forget to change the connector for the air side

hadrienp-met · 2024-06-24T13:12:23Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

@@ -0,0 +1,314 @@
+within MetroscopeModelingLibrary.MultiFluid.HeatExchangers;
+model CoolingTowerPoppe


Add a comment with the reference of the article we used

hadrienp-met · 2024-06-24T13:13:37Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+  parameter Integer N_step = 10; //Parameter specifies the number of sections for which the Cooling Tower thermodynamic properties are divided into in the loop.
+
+  //Unsaturated Air - Equations from Poppe Method for Cooling Tower Analysis
+  function f


Give a description for this function with the reference of the equation, see this example:

function quadrature "Integrate function y=integrand(x) from x1 to x2" input Real x1; input Real x2; input Integrand integrand; // Integrand is a partial function, see below // With default: input Integrand integrand := Modelica.Math.sin; output Real integral; algorithm integral :=(x2-x1)*(integrand(x1) + integrand(x2))/2; end quadrature;

hadrienp-met · 2024-06-24T13:14:00Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+    y:= (cp * (Qw / Qa) * (MoistAir.xsaturation_pT(Pin, Tw) - w)) / (((MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)})) - i + (Lef-1) * ((MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i - (MoistAir.xsaturation_pT(Pin, Tw) - w) * MoistAir.h_pTX(Pin, Tw, {1}))) - (MoistAir.xsaturation_pT(Pin, Tw) - w) * cp * Tw));
+  end f;
+
+  function g


Add a descriptions of the function

hadrienp-met · 2024-06-24T13:14:15Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+    y:= ((Qw * cp) / Qa) * (1 + (((MoistAir.xsaturation_pT(Pin, Tw) - w) * (cp * Tw)) / ((MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i + ((Lef-1) * (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i - (MoistAir.xsaturation_pT(Pin, Tw) - w) * MoistAir.h_pTX(Pin, Tw, {1}))) - (MoistAir.xsaturation_pT(Pin, Tw) - w) * cp * Tw))));
+  end g;
+
+  function h


Add a description of the function

hadrienp-met · 2024-06-24T13:14:47Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerMerkel.mo

+  import MetroscopeModelingLibrary.Utilities.Media.WaterSteamMedium;
+  import MetroscopeModelingLibrary.Utilities.Media.MoistAirMedium.specificEnthalpy;
+
+  Units.Velocity V_inlet;                  //Wind velocity entering cooling tower


Suggested change

Units.Velocity V_inlet; //Wind velocity entering cooling tower

Units.Velocity V_inlet; //Air velocity at the bottom of the cooling tower

hadrienp-met · 2024-06-24T13:23:57Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerMerkel.mo

+  Inputs.InputReal efan;                   //Fan effiency
+  Units.Power W_fan;                        //Fan power
+
+  parameter String configuration = "natural draft";


Suggested change

parameter String configuration = "natural draft";

parameter String configuration = "natural";

hadrienp-met · 2024-06-24T13:25:37Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+  //Supersaturated Air - Equations from Poppe Method for Cooling Tower Analysis
+  function j
+    input Real Tw;
+    input Real Ta;
+    input Real w;
+    input Real i;
+    input Real cp;
+    input Real Qw;
+    input Real Qa;
+    input Real Pin;
+    input Real Lef;
+    output Real y;
+  algorithm
+      y:= (cp * (Qw / Qa) * (MoistAir.xsaturation_pT(Pin, Tw) - MoistAir.xsaturation_pT(Pin, Ta))) / (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i + (Lef-1) * (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i - (MoistAir.xsaturation_pT(Pin, Tw) - MoistAir.xsaturation_pT(Pin, Ta)) * (MoistAir.h_pTX(Pin, Tw, {1})) + (w - MoistAir.xsaturation_pT(Pin, Ta)) * cp * Tw) + (w - MoistAir.xsaturation_pT(Pin, Tw)) * cp * Tw);
+  end j;


Suggested change

//Supersaturated Air - Equations from Poppe Method for Cooling Tower Analysis

function j

input Real Tw;

input Real Ta;

input Real w;

input Real i;

input Real cp;

input Real Qw;

input Real Qa;

input Real Pin;

input Real Lef;

output Real y;

algorithm

y:= (cp * (Qw / Qa) * (MoistAir.xsaturation_pT(Pin, Tw) - MoistAir.xsaturation_pT(Pin, Ta))) / (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i + (Lef-1) * (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i - (MoistAir.xsaturation_pT(Pin, Tw) - MoistAir.xsaturation_pT(Pin, Ta)) * (MoistAir.h_pTX(Pin, Tw, {1})) + (w - MoistAir.xsaturation_pT(Pin, Ta)) * cp * Tw) + (w - MoistAir.xsaturation_pT(Pin, Tw)) * cp * Tw);

end j;

function j "Supersaturated Air - Equations from Poppe Method for Cooling Tower Analysis"

input Real Tw;

input Real Ta;

input Real w;

input Real i;

input Real cp;

input Real Qw;

input Real Qa;

input Real Pin;

input Real Lef;

output Real y;

algorithm

y:= (cp * (Qw / Qa) * (MoistAir.xsaturation_pT(Pin, Tw) - MoistAir.xsaturation_pT(Pin, Ta))) / (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i + (Lef-1) * (MoistAir.h_pTX(Pin, Tw, {MoistAir.xsaturation_pT(Pin, Tw)}) - i - (MoistAir.xsaturation_pT(Pin, Tw) - MoistAir.xsaturation_pT(Pin, Ta)) * (MoistAir.h_pTX(Pin, Tw, {1})) + (w - MoistAir.xsaturation_pT(Pin, Ta)) * cp * Tw) + (w - MoistAir.xsaturation_pT(Pin, Tw)) * cp * Tw);

end j;

hadrienp-met · 2024-06-24T13:26:49Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+  Units.Temperature T_hot_in;
+  Units.Temperature T_hot_out;
+
+    // Poppe Inputs


Suggested change

// Poppe Inputs

hadrienp-met · 2024-06-24T13:27:35Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+
+  for n in 1:N_step-1 loop
+
+  if w[n] < w_sat[n] then


Add a few comments to explain the loop and the if condition

hadrienp-met · 2024-06-24T13:27:58Z

MetroscopeModelingLibrary/MultiFluid/HeatExchangers/CoolingTowerPoppe.mo

+   rho_air_inlet = air_inlet_flow.rho_in;
+   rho_air_outlet = air_outlet_flow.rho_out;
+
+   //if configuration = "natural draft" then


You can take the same equation of the Merkel model

phelimb-met and others added 9 commits March 27, 2024 15:49

Cooling tower first model

fecbf88

Correct air pressure

09c362f

Update

8f0cb64

sink/source

f3d9107

sink/source

2cf625c

balanced the component equations and got direct simulation to run

dec12b1

Causality correction

8db44a3

Correct component

1f5ac4a

balanced the component equations and got direct simulation to run

8289c87

hadrienp-met reviewed Apr 4, 2024

View reviewed changes

phelimb-met added 3 commits April 5, 2024 10:56

Update

b396da0

Update

b9a9f12

Update

b2b137f

hadrienp-met approved these changes Apr 5, 2024

View reviewed changes

hadrienp-met and others added 13 commits April 9, 2024 11:58

Update BCs values

f7abffa

poppe model

c047767

Poppe Model Update

78a0e7b

Update CT Poppe model

05bf4a6

Poppe Model Problem

3e1bd9d

Parameter definition outside the component

f150e11

Forgot a comment

59c7886

Latest Poppe Model

16790e5

Test function

ada350a

Pop Model

716c2f2

Poppe model update

64e7e62

Poppe model update

87697c5

Poppe Model with SS

5d870a1

hadrienp-met reviewed May 24, 2024

View reviewed changes

Update

e251278

phelimb-met added 3 commits May 27, 2024 11:02

merge

9bf1165

3/6

b8f1889

Forced Draft Cooling Tower

54c1b01

hadrienp-met reviewed Jun 24, 2024

View reviewed changes

phelimb-met added 5 commits June 26, 2024 09:59

Github Comments Implemented

b6e7cc4

Q_evap correction - Poppe

0c1907c

N_step = 20

852091b

15/7

7b377c0

Final Push

7aee51c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cooling tower first model #472

Cooling tower first model #472

phelimb-met commented Mar 27, 2024

hadrienp-met Apr 4, 2024

hadrienp-met Apr 4, 2024

hadrienp-met Apr 4, 2024

hadrienp-met Apr 4, 2024

hadrienp-met Apr 4, 2024

hadrienp-met left a comment

hadrienp-met left a comment

hadrienp-met May 24, 2024

hadrienp-met May 24, 2024

hadrienp-met May 24, 2024

hadrienp-met May 24, 2024

hadrienp-met May 24, 2024

hadrienp-met May 24, 2024

hadrienp-met May 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met left a comment

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

hadrienp-met Jun 24, 2024

	Units.Velocity V_inlet; //Wind velocity entering cooling tower
	Units.Velocity V_inlet; //Air velocity at the bottom of the cooling tower

		@@ -0,0 +1,314 @@
		within MetroscopeModelingLibrary.MultiFluid.HeatExchangers;
		model CoolingTowerPoppe

	parameter String configuration = "natural draft";
	parameter String configuration = "natural";

Cooling tower first model #472

Are you sure you want to change the base?

Cooling tower first model #472

Conversation

phelimb-met commented Mar 27, 2024

Goal

Type of change

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hadrienp-met left a comment

Choose a reason for hiding this comment

hadrienp-met left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hadrienp-met left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment