Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add us units to MML #494

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

LucileD-met
Copy link
Contributor

@LucileD-met LucileD-met commented Jul 22, 2024

Goal

Describe the big picture of your changes here (one sentence).
Closes #493 , by adding lbh (pounds per hour), ft3h (squared foot per hour) and inH20 (pressure) to MML flow and pressure sensors.

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass
  • I have checked that my work is compatible with OpenModelica
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@LucileD-met LucileD-met linked an issue Jul 22, 2024 that may be closed by this pull request
@LucileD-met LucileD-met self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add US flow units
1 participant