Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove superheaters fouling #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierre-eliep-met
Copy link
Collaborator

Goal

Superheaters fouling is not really a fault that happens on nuclear plants, because it is steam on both sides. It is an old REX from TVA.
So I just removed the variable, not that it is a breaking change for previous faulty models 😬

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass
  • I have checked that my work is compatible with OpenModelica
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@pierre-eliep-met pierre-eliep-met added the 🛠️ Faults For changes related to failures modeling label Aug 1, 2024
@pierre-eliep-met pierre-eliep-met self-assigned this Aug 1, 2024
@pierre-eliep-met
Copy link
Collaborator Author

(tiny PR to use a bit of extra time before the daily before my vacation 😇)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Faults For changes related to failures modeling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant