1928: Student absence from enrollments #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomca32
reviewed
Aug 15, 2024
| if current_enrollment_group_id is null then | ||
| insert into enrollments (student_id, group_id, active_since, inactive_since, created_at, updated_at) | ||
| values (new.id, new.group_id, now(), null, now(), now()); | ||
| else if current_enrollment_group_id != new.group_id then |
There was a problem hiding this comment.
What you're doing here is nesting the if inside the else branch so you need 2 end if statements at the end.
This works but we can clean it up by using elsif which is the plpgsql way to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat for #1928