Accepting ApplicationContext as an alternative #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding new constructor accepting applicationContext - Return applicationContext when possible in getApplicationContext
TheRealAgentK
requested changes
Jun 8, 2020
There was a problem hiding this comment.
- code duplication is not ideal, please change so that there's shared code both your new constructor and the existing constructor could use.
- new constructor in this setup needs to provide the same signature as the full-signature init(), otherwise missing version will cause issues.
provider/src/main/java/com/raygun/raygun4android/RaygunClient.java
Outdated
Show resolved
Hide resolved
provider/src/main/java/com/raygun/raygun4android/RaygunClient.java
Outdated
Show resolved
Hide resolved
|
Hi, @TheRealAgentK I've updated the implementation, can you please review? thanks |
|
Pulled in, will need further modifications though on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
We would like to consume this lib in another library which normally only have ApplicationContext available rather than Application.
Changes