Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customers Product]: Change references from 'User tracking' to 'Customers' 👥 #75

Conversation

sumitramanga
Copy link
Collaborator

@sumitramanga sumitramanga commented Feb 3, 2021

[Customers Product]: Change references from 'User tracking' to 'Customers' 👤

Description 📝

This PR is to updating the name convention for 'User tracking' to now be 'Customers' to reflect what's within the Raygun application.

NOTE: This is not to be merged until we have fully released the name change in the Raygun application

Updates
👉 Update README documentation
👉 Update sample app comment to refer to Customers

Test plan 🧪

  • Make sure documentation changes are reflected to be 'Customers' instead of 'User Tracking'

Checklist ✔️

  • Builds pass
  • Reviewed by another developer
  • Code is written to standards

@TheRealAgentK TheRealAgentK self-assigned this Feb 3, 2021
@TheRealAgentK TheRealAgentK self-requested a review February 3, 2021 03:43
@@ -77,7 +77,7 @@

- v1.0.3: Improved version tracking support

- v1.0.2: Added SetUser method for unique user tracking.
- v1.0.2: Added SetUser method for unique user tracking/customers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should avoid retrospectively changing the change log history.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to bump the provider version stating that we've made documentation changes instead? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not necessary because all you've been doing here is changing terminology in documentation and it's done in a really clear way, I think. In the past I haven't bumped the version for doc improvements.

Copy link
Contributor

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a ticket for changing the public API to use customer as well, but that'll be a process of phasing it in and deprecating the old API over the next 2 releases.

@TheRealAgentK TheRealAgentK merged commit 1718008 into master Feb 3, 2021
@sumitramanga sumitramanga deleted the sm/SS-607/update-user-tracking-docs-to-reference-customers branch November 9, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants