Build modernisation to modern Gradle/Android Studio #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id Extensions in favour of view binding
| // apply from: 'gradle-mvn-push.gradle' |
There was a problem hiding this comment.
Can we remove this all together or write a code comment as to why it's commented out
There was a problem hiding this comment.
No, I just commented it out because this contains all the gradle tasks for publishin the library builds to repo servers and that flow doesn't work at the moment. But it will be brought back.
There was a problem hiding this comment.
Ideally would be good to add that as a code comment but if it's in near future (upcoming PR?) then no worries :)
sumitramanga
requested changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What problem(s) does this PR solve?
Fixes the AS Gradle builds in so far that it's now up to date again with current Android studio version.
Type of change
What was done to solve the problem?
QA