Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Gradle 8 and AGP 8.1.1 #95

Merged
merged 7 commits into from
Nov 19, 2023
Merged

Conversation

TheRealAgentK
Copy link
Contributor

Migration to Gradle 8 and AGP 8.1.1

Description 📝

Fixes #89 and migrated the build over to Gradle 8 and AGP 8.1.1

Also fixes a bug where the sample app was outputting the incorrect provider version

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Updates

  • Build to Gradle 8+
  • AGP to 8.1.1
  • Java target to Java 17 as required by Gradle 8
  • UI bug fix in sample app re provider version

Test plan 🧪

Project shouldn't trigger "Upgrade Gradle to 8" any more. Builds should all still work across debug and release flavours.

Note: Deprecation warning for Gradle 9+ still trigger and will be resolved separately.

Author to check 👓

  • Project and all contained modules build
  • Tested on appropriate devices/emulators and SDK versions

- [] Reviewed by another developer
N/A

  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Change has been tested on a device/emulator
  • Code is written to standards

- [ ] Appropriate tests have been written (code comments, internal docs)
N/A

@TheRealAgentK TheRealAgentK marked this pull request as ready for review November 10, 2023 01:23
@sumitramanga
Copy link
Collaborator

Yay! image

@sumitramanga
Copy link
Collaborator

Will you be upgrading to the latest AGP in a later PR?

@sumitramanga
Copy link
Collaborator

Optional: It would be nice to have some feedback upon clicking the buttons within the providers test app. Such as, if you click there button, it should output some text that says 'Message sent' or 'Error sending message, check API key is valid'

@TheRealAgentK
Copy link
Contributor Author

Will you be upgrading to the latest AGP in a later PR?

Yeah, the AGP versions are somewhat tied to AS versions.

I think we should update when new AS versions are released. Hedgehog is currently in RC and Iguana in Canary - when Hedgehog comes out of RC, we'll bump AGP up accordingly.

@TheRealAgentK
Copy link
Contributor Author

Optional: It would be nice to have some feedback upon clicking the buttons within the providers test app. Such as, if you click there button, it should output some text that says 'Message sent' or 'Error sending message, check API key is valid'

Great suggestion:

#98

@sumitramanga
Copy link
Collaborator

Will you be upgrading to the latest AGP in a later PR?

Yeah, the AGP versions are somewhat tied to AS versions.

I think we should update when new AS versions are released. Hedgehog is currently in RC and Iguana in Canary - when Hedgehog comes out of RC, we'll bump AGP up accordingly.

I had to do a bit of reading to understand this 😄 It all makes sense now. Thank you! Android has so many concepts to keep up with. Does this change have an impact on the customer side or does it affect just developers of the provider

@sumitramanga
Copy link
Collaborator

Testing of the app went well. It sends CR and RUM data after rebuilding the project 👏

@sumitramanga
Copy link
Collaborator

sumitramanga commented Nov 14, 2023

One more comment before I approve. Some of these changes have been added automatically due to the upgrade, right? I had attempted to upgrade the AGP just to see what happens and that's what happened :)

Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤘

@TheRealAgentK
Copy link
Contributor Author

One more comment before I approve. Some of these changes have been added automatically due to the upgrade, right? I had attempted to upgrade the AGP just to see what happens and that's what happened :)

Yeah, the wizard from 7.4to 8.1 gets you some way there luckily, but it's patchy and inconsistent as well.

@TheRealAgentK
Copy link
Contributor Author

LGTM! 🤘

I'll make a few tweaks tomorrow re the small things we discussed and then merge it.

@TheRealAgentK TheRealAgentK merged commit f6423f7 into develop Nov 19, 2023
@TheRealAgentK TheRealAgentK deleted the feature/#89-gradle8 branch November 19, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle 8 support
2 participants