-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Gradle 8 and AGP 8.1.1 #95
Conversation
… bits I found when re-reading them.
Will you be upgrading to the latest AGP in a later PR? |
Optional: It would be nice to have some feedback upon clicking the buttons within the providers test app. Such as, if you click there button, it should output some text that says 'Message sent' or 'Error sending message, check API key is valid' |
Yeah, the AGP versions are somewhat tied to AS versions. I think we should update when new AS versions are released. Hedgehog is currently in RC and Iguana in Canary - when Hedgehog comes out of RC, we'll bump AGP up accordingly. |
Great suggestion: |
I had to do a bit of reading to understand this 😄 It all makes sense now. Thank you! Android has so many concepts to keep up with. Does this change have an impact on the customer side or does it affect just developers of the provider |
Testing of the app went well. It sends CR and RUM data after rebuilding the project 👏 |
One more comment before I approve. Some of these changes have been added automatically due to the upgrade, right? I had attempted to upgrade the AGP just to see what happens and that's what happened :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤘
Yeah, the wizard from 7.4to 8.1 gets you some way there luckily, but it's patchy and inconsistent as well. |
I'll make a few tweaks tomorrow re the small things we discussed and then merge it. |
Migration to Gradle 8 and AGP 8.1.1
Description 📝
Fixes #89 and migrated the build over to Gradle 8 and AGP 8.1.1
Also fixes a bug where the sample app was outputting the incorrect provider version
Type of change
Updates
Test plan 🧪
Project shouldn't trigger "Upgrade Gradle to 8" any more. Builds should all still work across
debug
andrelease
flavours.Note: Deprecation warning for Gradle 9+ still trigger and will be resolved separately.
Author to check 👓
- [] Reviewed by another developerN/A
Reviewer to check ✔️
- [ ] Appropriate tests have been written (code comments, internal docs)N/A