Feature/#98 feedbackonbuttons #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| xmlns:tools="http://schemas.android.com/tools" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="match_parent" | |||
| tools:context=".MainActivity"> | |||
| tools:context=".SecondActivity"> | |||
Comment on lines
+14
to
+19
| <string name="you_have_just_sent_an_error_with_raygun4android">You have just sent an error with Raygun4Android.</string> | ||
| <string name="you_just_created_and_caught_an_exception">You just created and caught an exception.</string> | ||
| <string name="user_is_now_set_to_anonymous_for_future_raygun_reports">User is now set to \'Anonymous\' for future Raygun reports.</string> | ||
| <string name="user_is_now_set_to_user_a_for_future_raygun_reports">User is now set to \'User A\' for future Raygun reports.</string> | ||
| <string name="user_is_now_set_to_user_b_for_future_raygun_reports">User is now set to \'User B\' for future Raygun reports.</string> | ||
| <string name="we_re_now_on_the_second_activity_screen">We\'re now on the second activity screen.</string> |
There was a problem hiding this comment.
Nitpick: some long string names, is that usual in this space? wondering if it's ok to shorten them or does it not make sense?
| import com.raygun.raygun4android.RaygunClient | ||
| import com.raygun.raygun4android.messages.crashreporting.RaygunBreadcrumbLevel | ||
| import com.raygun.raygun4android.messages.crashreporting.RaygunBreadcrumbMessage | ||
| import com.raygun.raygun4android.messages.shared.RaygunUserInfo | ||
| import java.util.* | ||
| import java.util.WeakHashMap |
| import android.util.Log | ||
| import android.widget.Button | ||
| import android.widget.TextView | ||
| import androidx.appcompat.app.AppCompatActivity | ||
| import com.google.android.material.snackbar.Snackbar |
There was a problem hiding this comment.
Love it 💯 Do you have screenshots/gif/screen recording of how it looks?
sumitramanga
requested changes
Feb 26, 2024
|
Hi @TheRealAgentK ! Just wanted to check in to see if you'll have time to work on this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes #98
Adds some Snackbar notification on actions in the sample app.
Type of change
Delete options that are not relevant.
Updates
👉 Added Material UI lib
👉 Added Snackbars on button actions, resource strings in
strings.xmlAuthor to check 👓
- [] Reviewed by another developerN/A
Reviewer to check ✔️
- [ ] Appropriate tests have been written (code comments, internal docs)N/A