-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#98 feedbackonbuttons #99
base: develop
Are you sure you want to change the base?
Conversation
@@ -4,7 +4,7 @@ | |||
xmlns:tools="http://schemas.android.com/tools" | |||
android:layout_width="match_parent" | |||
android:layout_height="match_parent" | |||
tools:context=".MainActivity"> | |||
tools:context=".SecondActivity"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍🏽
<string name="you_have_just_sent_an_error_with_raygun4android">You have just sent an error with Raygun4Android.</string> | ||
<string name="you_just_created_and_caught_an_exception">You just created and caught an exception.</string> | ||
<string name="user_is_now_set_to_anonymous_for_future_raygun_reports">User is now set to \'Anonymous\' for future Raygun reports.</string> | ||
<string name="user_is_now_set_to_user_a_for_future_raygun_reports">User is now set to \'User A\' for future Raygun reports.</string> | ||
<string name="user_is_now_set_to_user_b_for_future_raygun_reports">User is now set to \'User B\' for future Raygun reports.</string> | ||
<string name="we_re_now_on_the_second_activity_screen">We\'re now on the second activity screen.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: some long string names, is that usual in this space? wondering if it's ok to shorten them or does it not make sense?
import com.raygun.raygun4android.RaygunClient | ||
import com.raygun.raygun4android.messages.crashreporting.RaygunBreadcrumbLevel | ||
import com.raygun.raygun4android.messages.crashreporting.RaygunBreadcrumbMessage | ||
import com.raygun.raygun4android.messages.shared.RaygunUserInfo | ||
import java.util.* | ||
import java.util.WeakHashMap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used?
import android.util.Log | ||
import android.widget.Button | ||
import android.widget.TextView | ||
import androidx.appcompat.app.AppCompatActivity | ||
import com.google.android.material.snackbar.Snackbar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it 💯 Do you have screenshots/gif/screen recording of how it looks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments to address but otherwise mostly looks good! Thank you for implementing this change ⭐
Hi @TheRealAgentK ! Just wanted to check in to see if you'll have time to work on this? :) |
Description 📝
Fixes #98
Adds some Snackbar notification on actions in the sample app.
Type of change
Delete options that are not relevant.
Updates
👉 Added Material UI lib
👉 Added Snackbars on button actions, resource strings in
strings.xml
Author to check 👓
- [] Reviewed by another developerN/A
Reviewer to check ✔️
- [ ] Appropriate tests have been written (code comments, internal docs)N/A