Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a deep clone of the payload before passing it to a users call back function #493

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Create a deep clone of the payload before passing it to a users call back function #493

merged 4 commits into from
Aug 3, 2023

Conversation

darcythomas
Copy link
Contributor

@darcythomas darcythomas commented Jul 31, 2023 •
edited
Loading

Changed

  • The 'OnBeforeSend' and 'OnBeforeSendRUM' callbacks are now passed a clone of the payload, to prevent accidental pollution of global objects
  • Updated the Github Action (Pre commit unit tests) Node to version 20

@darcythomas darcythomas requested a review from Olwiba July 31, 2023 21:17
Olwiba
Olwiba reviewed Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@Olwiba Olwiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a description around why you want the change & also it looks like the package-lock was updated but I don't see any changes to the package.json - was there a mistake here?

@darcythomas
Copy link
Contributor Author

I don't see any changes to the package.json - was there a mistake here?

I did a npm update i think that did that

@darcythomas
bump version
0b061ab 
Update index.js

Update index.js

Update raygun.js

Update index.js

Update index.js

Update package.json

Update package-lock.json

Update raygun.js

Update tests.yml

Update package.json

Update package-lock.json

Update package-lock.json

Update raygun.js

Update index.js
@darcythomas
Update CHANGELOG.md
9c2b4c4 
Revert "post merge"

This reverts commit 28dfbb3.

post merge
@darcythomas darcythomas requested a review from Olwiba August 1, 2023 00:19
Olwiba
Olwiba approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@Olwiba Olwiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@darcythomas
Copy link
Contributor Author

Ok presoaking now

@darcythomas darcythomas changed the title Create a deep clone of the payload before giving to users call back function Create a deep clone of the payload before passing it to a users call back function Aug 2, 2023
@darcythomas darcythomas merged commit f2c704b into master Aug 3, 2023
1 check passed
@darcythomas darcythomas deleted the darcy/safer-callback-data branch August 3, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olwiba Olwiba Olwiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darcythomas @Olwiba