Darcy/with tags as a function fix #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olwiba
reviewed
Aug 8, 2023
src/raygun.js
Outdated
| @@ -952,9 +952,16 @@ var raygunFactory = function(window, $, undefined) { | |||
| payload.Details.GroupingKey = _groupingKeyCallback(payload, stackTrace, options); | |||
| } | |||
|
|
|||
| var clonedPayload = (!!window.structuredClone ? window.structuredClone(payload): payload); //clone in supported browsers (everything but IE) | |||
| var clonedPayload = payload; | |||
Olwiba
reviewed
Aug 8, 2023
There was a problem hiding this comment.
are you able to provide a more details explanation of the changes in the PR description?
the code changes look fine but hard to understand how the order of operations have changed at a glance and would prefer to approve understanding this rather than just looking at the code changes
Olwiba
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent errors on structured clone from propagating
raygun.js has this line:
var clonedData = (!!window.structuredClone ? window.structuredClone(data): data); //clone in supported browsers (everything but IE)but
window.structuredClonethrows if it encounters a function (https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm#things_that_dont_work_with_structured_clone).When using
rg4js('withTags', getCustomTags); ( [Documentation] (https://raygun.com/documentation/language-guides/javascript/advanced-setup/#withtags) ), this is causing an error to be thrown, becausedata..eventData[].Tags` can be a function.The fix here is to attempt to perform a structured clone, but fall back to the original behaviour is that is not possible.