Custom timings showing on pages that arent-related #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcythomas
force-pushed
the
darcy/WORM-253/custom-timings-showing-on-pages-that-arent-related
branch
from
c4b94a3
to
b799e9b
Compare
darcythomas
changed the title
Olwiba
approved these changes
Aug 30, 2023
darcythomas
added a commit
that referenced
this pull request
Aug 30, 2023
This reverts commit 65a6098.
Merged
darcythomas
added a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare circumstance a custom timing may be created before the raygun4js has fully initialized.
In this case then event is queued for sending later.
In some very rare cases by the time the event is sent the page (and therefore the parent resource) has changed.
This can result in some timings being miss-attributed to the wrong page.
This pr tries to get the parent resource before the event is queued.