Notes for CS-9 #507
Closed
Notes for CS-9 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olwiba
reviewed
Sep 19, 2023
Comment on lines
+163
to
+165
| // One idea is to have a typeof bonusUrl | ||
| //Where we extract a real url and a reporting one | ||
| //The user would then need to call fetch({realUrl: "http//:abv.com/api/allTheThings", reportingUrl: "http//:abv.com/api/allTheThings#GetUser(zyz)"}, BODY) |
There was a problem hiding this comment.
I can see something like this working, although, I feel this has definitely fallen into the realm of a feature request.
This is a good thing because with this it can get a group discovery, project plan & appropriate testing if selected for development rather than being an item on someone's list.
I've validated that there is simply no payload information available inside the onBeforeXHR or onBeforeRUM calls so I think I'll put a cork in it and move on. I dabbled with the idea of monkey-patching the window fetch/XHR prototypes but this is more of a hack & I don't think it would ever be something we recommend to customers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.