Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in fetching XHR url for breadcrumbs #516

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

Hamish-taylor
Copy link
Contributor

This bug fixes a typo in the breadcrumbs code when it try's to fetch the URL for a failed request.

This bug was raised in #508.

message: 'Failed request to ' + error.requestUrl,

error.requestUrl should be error.requestURL

Before

image

After

image

Copy link
Collaborator

@Olwiba Olwiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look safe to me. I'm happy for this to go out 🚀

Copy link

@PanosNB PanosNB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. As a follow up, please look if this (and similar) could be at least triggering a Crash error at Raygun during presoaking the prerelease

@PanosNB
Copy link

PanosNB commented Jan 31, 2024

I'm happy for this to go to production. Small change and was tested in prerelease on our website

@Hamish-taylor Hamish-taylor merged commit f2be885 into master Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants