Resolve jQuery isFunction warning #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redJ4y
force-pushed
the
js/fix-jquery-isfunction-deprecation
branch
from
ddcece9
to
4228e2e
Compare
redJ4y
commented
Aug 19, 2024
| @@ -55,7 +55,7 @@ | |||
|
|
|||
| var keys = ['complete', 'error', 'success'], key; | |||
| while(key = keys.pop()) { | |||
| if ($.isFunction(options[key])) { | |||
| if (typeof options[key] === "function") { | |||
There was a problem hiding this comment.
This is the only change to the provider. The rest is related to Continuous Integration tests.
redJ4y
force-pushed
the
js/fix-jquery-isfunction-deprecation
branch
from
b9643d8
to
e5784b7
Compare
redJ4y
force-pushed
the
js/fix-jquery-isfunction-deprecation
branch
from
bc6a004
to
58c4a6e
Compare
redJ4y
force-pushed
the
js/fix-jquery-isfunction-deprecation
branch
from
97759d0
to
a5fadcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue raised by Mattybat on the Raygun forums.
See https://api.jquery.com/jQuery.isFunction/
This PR also
package.json,prerelease.yml.