Fix SendInBackground for iOS #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environment message details required that they be accessed on the UI thread. When using SendInBackground this would silently fail, so we now ensure that the message is created on the Main thread.
Added change log
phillip-haydon
approved these changes
Mar 1, 2024
xenolightning
suggested changes
Mar 3, 2024
Invoking on UI thread each time to construct the method not only is inefficient, but it may also prevent unhandled exceptions from being processed. We now hook into the MainDisplayInfoChanged event handler to update the dynamic environment details when needed.
xenolightning
suggested changes
Mar 6, 2024
|
Testing of the new changes show that the ILogger spam issue goes away and the SendInBackground on iOS works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
During the creation of the RaygunEnvironmentMessage on iOS some fields require that they are accessed on the Main/UI thread. Previously, the provider was silently failing on this and the crash report would never be send to Raygun. This would also cause an infinite loop if ThrowOnError was enabled.
Fix:
Construct the RaygunEnvironmentMessage on the Main/UI thread and then hand back to the thread the SendInBackground call is using.
Testing: