RUM Support for Raygun4Maui #16

ProRedCat · 2024-03-19T02:07:27Z

Raygun4Maui v2.0.0

Adds support for Real User Monitoring (RUM) for Windows, Android, iOS, and MacCatalyst

Implemented RUM Features:

Page Tracking
Page Load Times
- Time between PageDisappearing and PageAppearing
Session Tracking
Custom Timings
- Supports "t" type timings
Native iOS Timings
- iOS/MacCatalyst specific
Network Timings
- See README.md for support information

Provider Changes

Raygun4MauiSettings no longer inherits from RaygunLoggerConfiguration
- RaygunSettings and RaygunLoggerConfiguration are now child elements
- RaygunLoggerConfiguration no longer inherits RaygunSettings
Changes .AddRaygun4Maui to .AddRaygun
- Introduces appsettings.json style configuration options
- Adds overload for appsettings.json configuration method with an Action<Raygun4MauiSettings> to change settings at runtime
- Keeps overload for .AddRaygun(Raygun4MauiSettings) - other two are more recommended
Adds more configuration options for RUM features
- IgnoredViews a list of views to ignore when tracking
- IgnoredUrls a list of url's to ignore when tracking
- RumApiEndpoint endpoint to where the RUM data is sent
- EnableRealUserMonitoring to enable RUM - defaults to true
- RumFeatureFlags a enum flag to enable specific RUM features, (e.g. RumFeatures.Page | RumFeatures.Network)
Adds Raygun4MauiSettings to service provider for DI dependent services to edit it
Includes fixes from Raygun4Maui 1.4.1 and 1.4.2
- 1.4.1
  - Fixes Android native crash due to concurrent access to environment information
- 1.4.2
  - Fixes issues on iOS when sending a crash report on another thread
  - Fixes Android crash when ILogger is spammed with logs/errors
Minor version bump for Raygun4Net.NetCore to 8.2.0
- Raygun4Net.NetCore now handles the unhandled exceptions
- Introduces ThrottledBackgroundMessageProcessor
Major version bump for Raygun4Net.NetCore to v10.0.0 see changes
- Brings in IRaygunUserProvider which we wrap in an abstract class called RaygunMauiUserProvider
- Obsoletes User and UserInfo in the Raygun client
  - User and UserInfo are no longer supported in Raygun4Maui
- Fixes uninstantiated fields in Raygun message causing null pointers
- Fixes situations where Raygun client settings did not reflect the RaygunSettings object
Minor version bump for Raygun4Net.NetCore v10.1.0
- Allows environment variables to be included in the crash report see changes

Implemented: Page tracking/load times Sessions User tracking Custom timings Network tracking - Attempted Packages added: Newtonsoft (for serialization) Todo: Review architecture Clean-up implementation

Added Android app lifecycle events and fixed the RaygunAppEventPublisher where multiple listeners were added to pages because of duplicate AppStarted events.

Requires testing

Disabled networking as it does not work on iOS and Android

The library was previously compiled for iPhoneOS arm64, and iPhoneSimulator x64 as it was compiled before Apple Silicon. This would prevent the project form being compiled as it would try linking the arm64 iPhoneSimulator to the x64 library. The library has now been compiled for iPhoneOS arm64, and iPhoneSimulator arm64/x64.

Also fixes issue where requests to api.raygun.com/entries and /events were not being ignored.

Raygun4Maui/Raygun4MauiSettings.cs

Deacon-McIntyre

Checkpoint, submitting my comments so far while I review the remaining files

CHANGE-LOG.md

README.md

CHANGE-LOG.md

README.md

Raygun4Maui/MauiRUM/EventTrackers/RaygunSessionTracker.cs

Raygun4Maui/MauiRUM/EventTrackers/Apple/RaygunAppleNativeNetworkMonitor.cs

Raygun4Maui/MauiRUM/EventTrackers/Android/RaygunAndroidNativeNetworkTracker.cs

Fixes spelling issues and removes dead code

Deacon-McIntyre

Looks pretty good, thanks for changing the default EnableRealUserMonitoring value!

Just a list of minor stuff pretty much 🙂

Raygun4Maui/MauiRUM/EventTrackers/Windows/RaygunWindowsNetworkMonitor.cs

Raygun4Maui/MauiRUM/EventTypes/RaygunRumEventTimingType.cs

Raygun4Maui/MauiRUM/RaygunRum.cs

Raygun4Maui/MauiRUM/EventTrackers/Apple/RaygunAppleNativeNetworkMonitor.cs

Raygun4Maui/MauiRUM/RaygunRum.cs

Raygun4Maui/MauiRUM/RaygunWebRequestHandler.cs

Raygun4Maui/NativeDeviceInfo.cs

Raygun4Maui/Raygun4MauiExtensions.cs

Raygun4Maui/Raygun4Net.RaygunLogger/RaygunLogger.cs

Deacon-McIntyre · 2024-03-20T02:21:53Z

Raygun4Maui/RaygunMauiClient.cs

        }

-        public RaygunMauiClient(string apiKey) : base(apiKey)
+        // TODO: Will this actually be used, and how does it work with IRaygunUserProvider


Have these questions been answered?

Not yet, @phillip-haydon any thoughts on if we should be using an IOptions instantiation of the Raygun4MauiClient? Currently, through our extension methods, we do not hit this code path so it likely does not need to be supported.

phillip-haydon

Looking good, got a couple of questions and some OCD kicking off.

phillip-haydon · 2024-03-20T20:52:54Z

CHANGE-LOG.md

+- Native iOS Timings
+  - iOS/MacCatalyst specific
+- Network Timings
+  - See README.md for support information


This can be a link to the readme.

Raygun4Maui/MauiRUM/EventTrackers/RaygunSessionTracker.cs

Raygun4Maui/MauiRUM/EventTrackers/RaygunViewTracker.cs

Raygun4Maui/MauiRUM/EventTrackers/Windows/RaygunWindowsNetworkMonitor.cs

Raygun4Maui/MauiRUM/RaygunRumTimingData.cs

Raygun4Maui/MauiRUM/RaygunRumTimingInfo.cs

Raygun4Maui/MauiRUM/RaygunSerializer.cs

Raygun4Maui/Raygun4MauiExtensions.cs

Raygun4Maui/RaygunMauiUserProvider.cs

ProRedCat · 2024-04-15T22:08:41Z

Raygun4Maui/Raygun4MauiExtensions.cs

+            mauiAppBuilder.Services.AddSingleton<IRaygunMauiUserProvider, RaygunMauiUserProvider>();
+
+            mauiAppBuilder.Services.AddSingleton<IRaygunUserProvider>(sp => sp.GetRequiredService<IRaygunMauiUserProvider>());


This is done so when we inject the IRaygunUserProvider or IRaygunMauiUserProvider and receive the same instance.

This allows the RaygunClient to get an instance of IRaygunUserProvider that will have the same user as available to RUM. Aliasing like this also allows for injection of the IRaygunMauiUserProvider so we do not have to cast to IRaygunMauiUserProvider to call SetUser.

ProRedCat · 2024-04-15T22:09:32Z

Raygun4Maui/Raygun4MauiExtensions.cs

+        public static MauiAppBuilder AddRaygunUserProvider<T>(this MauiAppBuilder mauiAppBuilder) where T : class, IRaygunMauiUserProvider
+        {
+            mauiAppBuilder.Services.AddSingleton<IRaygunMauiUserProvider, T>();
+            return mauiAppBuilder;
+        }


We should only need to add an implementation for the IRaygunMauiUserProvider when setting a custom user provider due to the way it was implemented as mentioned above

ProRedCat and others added 30 commits January 18, 2024 16:41

Spike implementation of MAUI RUM

95f57f8

Implemented: Page tracking/load times Sessions User tracking Custom timings Network tracking - Attempted Packages added: Newtonsoft (for serialization) Todo: Review architecture Clean-up implementation

Raygun4MauiSettings refactor and client attatchment

e62fb93

Rum feature flags

e2a11f0

Changed from Newtonsoft to SimpleJson

fb1d3b8

Added obsolete tags on AddRaygun4Maui methods

cdce698

RaygunAppEventPublisher architecture change and message body formatting

01a3082

Changed platform for session event

73fabae

Changed method body serialization

9fa89ac

Update README.md

69187d8

Updated versions for pre-release

76066d9

Added Android app lifecycle events

ab940b6

Added Android app lifecycle events and fixed the RaygunAppEventPublisher where multiple listeners were added to pages because of duplicate AppStarted events.

Updated version for Android release

3cfbdea

Added iOS/MacCatalyst app lifecycle events

8990c85

iOS and MacCatalyst View Observer Swizzling

89c7b40

Requires testing

Implemented network monitoring

cbd44d3

Fixed initialization issues, enabled Swizzling

1ebd137

Disabled networking as it does not work on iOS and Android

Untangled RaygunLoggerConfiguration, changed to bundled appsettings.json

b3263e5

Renamed native apple timings variable

de2c55f

Updated projects for rc-3

1e0938b

Update README.md

ac83426

Android networking and iOS networking

c1da9d3

iOS networking and Windows networking updates

53693d2

Raygun4Net 8.2.0 refactor and rebase cleanup

cef7732

Fixed Android network monitor library

e3d4a0a

Updated release note link

c84af0f

iOS Networking fix for HttpClient and rc-4 changes

fae61a7

Versioning fixes for iOS networking

690656c

Added MacCatalyst networking

21457e3

RC-5 Version bump

baa0fe3

ProRedCat added 8 commits March 18, 2024 14:48

Added CR environment variable support

c1b44ac

Fix Windows display info not populated

78b852a

MAUI v2.0.0 tidy up

73520e5

Typo in build platforms

345125a

Removed unused field from DeviceIdProvider

74f5373

Release notes changed to CHANGE-LOG.md

bf39178

Log HTTP or HTTPS for Windows network monitoring

081f2ff

Also fixes issue where requests to api.raygun.com/entries and /events were not being ignored.

Updates CHANGE-LOG.md for release

c6ea4fb

ProRedCat requested review from phillip-haydon, xenolightning and Deacon-McIntyre March 19, 2024 02:07

Update CHANGE-LOG.md

0d2fe6a

phillip-haydon reviewed Mar 19, 2024

View reviewed changes

Raygun4Maui/Raygun4MauiSettings.cs Show resolved Hide resolved

Deacon-McIntyre reviewed Mar 20, 2024

View reviewed changes

Changes RUM default enable to false and cleans up code

c6df926

Fixes spelling issues and removes dead code

Deacon-McIntyre reviewed Mar 20, 2024

View reviewed changes

xenolightning removed their request for review March 20, 2024 02:33

ProRedCat added 3 commits March 20, 2024 16:45

Style changes

5e43b1a

Removed missed commented log statement

135e55f

Update README.md

3ef55ce

phillip-haydon reviewed Mar 21, 2024

View reviewed changes

velocitysystems reviewed Mar 21, 2024

View reviewed changes

Raygun4Maui/RaygunMauiUserProvider.cs Outdated Show resolved Hide resolved

velocitysystems reviewed Mar 21, 2024

View reviewed changes

Raygun4Maui/RaygunMauiUserProvider.cs Outdated Show resolved Hide resolved

ProRedCat added 2 commits April 16, 2024 09:54

Adds default implementation for IRaygunMauiUserProvider

54b20e1

Cleanup and PR changes

8a5dccb

ProRedCat commented Apr 15, 2024

View reviewed changes

Updated user provider documentation in README

2e353e3

phillip-haydon approved these changes Apr 23, 2024

View reviewed changes

ProRedCat merged commit 637912c into master Apr 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RUM Support for Raygun4Maui #16

RUM Support for Raygun4Maui #16

ProRedCat commented Mar 19, 2024 •

edited

Loading

Deacon-McIntyre left a comment

Deacon-McIntyre left a comment

Deacon-McIntyre Mar 20, 2024

ProRedCat Mar 20, 2024

phillip-haydon left a comment

phillip-haydon Mar 20, 2024

ProRedCat Apr 15, 2024

ProRedCat Apr 15, 2024

		mauiAppBuilder.Services.AddSingleton<IRaygunMauiUserProvider, RaygunMauiUserProvider>();

		mauiAppBuilder.Services.AddSingleton<IRaygunUserProvider>(sp => sp.GetRequiredService<IRaygunMauiUserProvider>());

RUM Support for Raygun4Maui #16

RUM Support for Raygun4Maui #16

Conversation

ProRedCat commented Mar 19, 2024 • edited Loading

Raygun4Maui v2.0.0

Implemented RUM Features:

Provider Changes

Deacon-McIntyre left a comment

Choose a reason for hiding this comment

Deacon-McIntyre left a comment

Choose a reason for hiding this comment

Deacon-McIntyre Mar 20, 2024

Choose a reason for hiding this comment

ProRedCat Mar 20, 2024

Choose a reason for hiding this comment

phillip-haydon left a comment

Choose a reason for hiding this comment

phillip-haydon Mar 20, 2024

Choose a reason for hiding this comment

ProRedCat Apr 15, 2024

Choose a reason for hiding this comment

ProRedCat Apr 15, 2024

Choose a reason for hiding this comment

ProRedCat commented Mar 19, 2024 •

edited

Loading