Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline crash report storage for MAUI #19

Merged
merged 8 commits into from
Jun 9, 2024
Merged

Add offline crash report storage for MAUI #19

merged 8 commits into from
Jun 9, 2024

Conversation

xenolightning
Copy link
Contributor

Store these in the FileSystem.AppDataDirectory - with a randomly generated folder ID

@xenolightning
Add offline crash report storage for MAUI
b60ca2e 
Store these in the FileSystem.AppDataDirectory - with a randomly generated folder ID
ProRedCat
ProRedCat approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@ProRedCat ProRedCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, assuming this works on iOS/Mac Catalyst (they may have some weird permission issues)

ProRedCat
ProRedCat reviewed Jun 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
ProRedCat
ProRedCat approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@ProRedCat ProRedCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just one minor semantic comment

ProRedCat
ProRedCat approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@ProRedCat ProRedCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

ProRedCat
ProRedCat reviewed Jun 9, 2024
View reviewed changes
CHANGE-LOG.md Outdated Show resolved Hide resolved
ProRedCat
ProRedCat approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@ProRedCat ProRedCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@xenolightning xenolightning merged commit fff1a1d into master Jun 9, 2024
@xenolightning xenolightning deleted the sean/maui-offline-store branch June 9, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProRedCat ProRedCat ProRedCat approved these changes

@PanosNB PanosNB Awaiting requested review from PanosNB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xenolightning @ProRedCat