Portable PDB + Offline Store Support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…common library This might have an impact on the public api surface, so might require a major bump. Can be undone if we decide this is a no go
ProRedCat
reviewed
Jun 16, 2024
ProRedCat
reviewed
Jun 16, 2024
ProRedCat
reviewed
Jun 17, 2024
ProRedCat
reviewed
Jun 17, 2024
ProRedCat
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Lgtm, nice work on selecting the ABI specific package - that could have been a tricky bug
Just some further notes for visibility, this should all work but it's possible when an app is deployed to the app store some shenanigans take place which break this so we should keep an eye on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.