Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency bump on Raygun4Net #7

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Dependency bump on Raygun4Net #7

merged 2 commits into from
Nov 15, 2023

Conversation

phillip-haydon
Copy link
Contributor

Dependency bump on Raygun4Net and added some tests for Serilog usage in MAUI apps.

CmdrKeen
CmdrKeen approved these changes Nov 15, 2023
View reviewed changes
Copy link

@CmdrKeen CmdrKeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We discussed a few things off the PR. Specifically, that the minorVersion in the global file helps pin to .NET 6 when deving on the code.

Similarly the image removal on the sample app has no negative impact.

@phillip-haydon phillip-haydon merged commit 2b67d53 into master Nov 15, 2023
@phillip-haydon phillip-haydon deleted the ph/dependency-bump branch November 15, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CmdrKeen CmdrKeen CmdrKeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-haydon @CmdrKeen