Build message before queuing it #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillip-haydon
requested review from
QuantumNightmare,
PanosNB and
sumitramanga
|
How much are we talking in terms of " huge number of exceptions" for the overhead issue? |
When we tested it, we chucked it in a loop sending 100k exceptions to see what happened with the memory, it grew a little bit more than if it was delegated, not enough to cause a problem, but just didn't want people to think we were having a memory leak. This change is more important than ~10mb of data showing up in memory profiling though. |
|
Possibly fixes #536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required for updates to Serilog provider where Serilog uses the base implementation of
SendInBackgroundbut depends onIRaygunUserProviderto get the user info fromHttpContextAccessor.HttpContextWhen the build message is sent as a delegate to
Enqueueit gets executed out of context and the information is lost.There is a minor overhead in memory building the message up front but this only occurs when there's a huge number of exceptions being thrown.