Feature - Add support for scrapy #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-holt
reviewed
Jan 16, 2020
| f = failure.Failure() | ||
| return f | ||
|
|
||
| def test__handler_exception_called(self): |
There was a problem hiding this comment.
Is the double underscore here deliberate? Expected test_handler_exception_called
|
@luke-falvey I don't know enough about this provider (or language) to give a good review at this point unfortunately. Also is this PR still applicable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrapy is a popular web crawling and web scraping framework implemented in python. Like Django middleware, scrapy provides extensions that allows custom functionality to be inserted into the framework. This PR implements an extension that automatically send errors to Raygun when exceptions are raised in the spider and item pipelines.
TODO:
setup.py