Updated middleware Providers to take Sender config, fixed wsgi CONTENT_LENGTH error #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of Werkzerg created a default of '' for the CONTENT_LENGTH environ var if the client did not provide the header. See pallets/werkzeug#1056
markstuart
commented
Apr 8, 2020
| if content_length: | ||
| http_form = request['wsgi.input'].read(content_length) | ||
| content_length = request.get('CONTENT_LENGTH', 0) | ||
| if content_length and content_length != '': |
There was a problem hiding this comment.
Some wsgi servers set the CONTENT_LENGTH to '' if the client did not provide the header. This was happening in my case and the result was that the attempt to cast '' to an int was raising an exception, and the try:except was handily swallowing the error.
The result was that rg_request never got instantiated and was failing later on when trying to set rg_request['headers'] = _headers.
I think this change should be compatible with the intent of what was there previously. It does however mean that the http_form would not get created if request.get('CONTENT_LENGTH') == ''
markstuart
changed the title
|
hey folks, any chance this can get merged and have a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using raygun4py in a project where it's already used as wsgi middleware. Recently we found that some of the env vars going through to Raygun we wanted to filter out, and it seems the way to do that is via config to the RaygunSender when initialising it.
Unfortunately, only the Django middleware supports this, so I raised this PR to hopefully get the other middlewares up to the same level.