Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idiv2: to do list #21

Open
49 of 57 tasks
rueuntal opened this issue Jul 5, 2016 · 8 comments
Open
49 of 57 tasks

idiv2: to do list #21

rueuntal opened this issue Jul 5, 2016 · 8 comments

Comments

@rueuntal
Copy link
Contributor

rueuntal commented Jul 5, 2016

  • smooth out sSBR by averaging it over at a minimum 20 runs. Currently the sSBR looks very jagged which largely reflects the particulars of the random walk that it took in sampling. By doing this several times a smoother and a less biased estimate of the expected S can be obtained although it will be slower.
  • improve documentation for function rarefaction so it is clear what the different methods accomplish
  • add subset.mob_in function that aids in pulling out a reduced number of rows of the mob_in object - this can be really useful when wanting to only work with certain treatment combinations
  • acknowledge Marc Taylor for plotStacked function (https://github.com/marchtaylor/sinkr/blob/master/R/plotStacked.R) also thank Anne Chao and collegues for various functions --> this also requires us to copy and paste there functions for our purposes rather than maintain the dependancies on their package.
  • stacked bar chart with pie charts
  • implement spatial anaylsis when geographic coordinates are not available this changes interpretation from implicit and explicit spatial aggregation to just focusing on implicit spatial aggregation
  • get rid of plot_rarefy and move that code into plot.mob_out which currently calls that function.
  • implement the same log argument in plot.mob_out as in mob_out
  • remove the function that does the 3d plot (and breaks when the code is executed on a server)
  • change ScaleBy to ref_group
  • Anova type output based on a ref group
  • Agree on how to scale between # individuals and # plots
  • Regression type
    • Regression analysis
    • null tests for regression?
      • test 1 - complete individual randomization
      • test 2 -
      • test 3
      • sensitivity analysis
  • function at the beginning to check that rows (plots) between two data frames match
  • define object class mob_out (print, plot) and mob_in (print, t-test, summary -> t-test table)
    • summary.mob_in should provide p-values rather than quantiles
  • other functions
    • print
    • plot
      • rarefaction plots these will pair with the delta S plots
        • rarefaction plot legend sometimes mislabels the curves (high priority)
    • modify plot.mob_out to either plot delta curves or raw curves or both
      • It appears that plot.mob_out sometimes log transforms the x axis depending on mob_out$log_scale and sometimes does not. This needs to be made consistent across the figures. (high priority)
      • improve code in plot.mob_out
      • add number of samples to axis see old axis labels
      • nick requests that for the individual based rarefaction we show the entire curve across all samples and not just for the smallest number of individuals common across the groups.
    • trim delta plots to ignore n < 5 individuals due to the artifact that it must interested at 0.
    • box plots of univariate analyses
      • N vs trt
      • S rarefied vs trt
      • PIE rarefied vs trt
      • Beta PIE rarefied vs trt
      • S vs trt
    • summary
  • cleanup and combine categorical case (anova) with continuous case (regression)
  • test for composition? (*maybe later)
  • complex exp design with more than one factor? (*maybe later)
  • package up
  • figure out what's going on with null test for N
  • modify function rarefaction so it will accept a vector for sample based rarefaction
  • add extrapolated S to the boxplot
  • fix null test for aggregation
  • add output of number of permutations to mobr object output from get_delta_stats
  • occupancy data (low priority can only be applied to spatial rarefaction)
  • track down warning message from rarefaction for coffee and cattle datasets: "1: In rarefaction(comm, "indiv", inds) :" Also the ant 2014 dataset is producing the following error: "In deltaS_N(comm_perm[plot_levels == x, ], plot_dens_level, ... :
    Extrapolating the rarefaction curve because the number of rescaled individuals is smaller than the inds argument "effort" larger than total number of samples
  • document package
    • mobr.package documentation
  • note in the documentation of the function rarefaction that sample-based rarefaction is not actually used anywhere in the mob methods.
  • provide 3d plot option for headless machine (low priority) currently implemented with rgl
  • repeat sensitivity analysis for the discrete case after fixing the warnings & also implement with larger number of iterations
@dmcglinn
Copy link
Member

Folks keep adding things to the list of ToDo as you encounter them in the code

@dmcglinn
Copy link
Member

@rueuntal and @FelixMay where are we on this list of to do's from last meeting?

@FelixMay
Copy link
Contributor

@dmcglinn I feel responsible for the boxplots and for a vignette for mobr. However, with the latter I would like to wait until the normal function documentation is there. So let me know when you documented the functions. I will only be able to devote time, after November 9, which means after our iDiv conference

@rueuntal
Copy link
Contributor Author

Hey @dmcglinn - sorry about the delay! My family are in town, so I'm a bit lagging behind. If I remember correctly, there are a few things that we have agreed not to include, at least not in this first release:

  • analysis for composition

  • complex experiment designs with multiple factors

  • (continuous case - did we agree to postpone this as well?)

    The remaining big things on my mind at the moment are:

  • make sure that the supporting functions (e.g., plot, summary, etc.) work and the outputs match what we have in mind;

  • help documents for each function;

  • bump up the number of iterations for the sensitivity analysis, to be done on iDiv's server.

Anything else?

@FelixMay
Copy link
Contributor

Hey @dmcglinn, I will take care of the documentation for the mob_stats and the boxplots function. However, so far I only worked on the master branch. Should I add the new stuff to the 4cur branch? Does that mean I also have to fork this branch or can I chose when I push and pull to which branch this happens? Thanks!

@dmcglinn
Copy link
Member

dmcglinn commented Nov 29, 2016 via email

@FelixMay
Copy link
Contributor

FelixMay commented Nov 29, 2016 via email

@dmcglinn
Copy link
Member

I just added additional items from the Felix to do list to a more general todo list for @rueuntal and myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants