Skip to content

Commit

Permalink
src: remove v8abbr.h
Browse files Browse the repository at this point in the history
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: nodejs#43652
PR-URL: nodejs#44402
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
  • Loading branch information
tniessen authored and MoLow committed Sep 7, 2022
1 parent c0cfb14 commit 2ea7dcb
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 129 deletions.
2 changes: 1 addition & 1 deletion .github/label-pr-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ subSystemLabels:
/^src\/tty_/: c++, tty
/^src\/node_url/: c++, whatwg-url
/^src\/node_util/: c++, util
/^src\/(?:node_v8|v8abbr)/: c++, v8 engine
/^src\/node_v8/: c++, v8 engine
/^src\/node_contextify/: c++, vm
/^src\/.*win32.*/: c++, windows
/^src\/node_zlib/: c++, zlib
Expand Down
9 changes: 5 additions & 4 deletions src/node_postmortem_metadata.cc
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
#include "env.h"
#include "base_object-inl.h"
#include "env.h"
#include "handle_wrap.h"
#include "util-inl.h"
#include "req_wrap.h"
#include "v8abbr.h"
#include "node_context_data.h"
#include "req_wrap.h"
#include "util-inl.h"

#define NODE_OFF_EXTSTR_DATA sizeof(void*)

#define NODEDBG_SYMBOL(Name) nodedbg_ ## Name

Expand Down
123 changes: 0 additions & 123 deletions src/v8abbr.h

This file was deleted.

3 changes: 2 additions & 1 deletion test/cctest/test_node_postmortem_metadata.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
#include "req_wrap-inl.h"
#include "tracing/agent.h"
#include "v8.h"
#include "v8abbr.h"

#define NODE_OFF_EXTSTR_DATA sizeof(void*)

extern "C" {
extern uintptr_t
Expand Down

0 comments on commit 2ea7dcb

Please sign in to comment.