fix: Skip phone number validation when country code is unknown

[barbeau]

Summary:

This PR ensures that phone number validation is skipped when country code is unknown (invalid or unprovided). Adds a unit test for this case as well.

Closes #1058.

Background:

The intent of making the country code optional in PR #851 was to skip phone number validation if country code wasn't provided at the command line. Apparently in the main branch phone number validation is run even when the country code is not provided or unknown.

I'm not sure if there was a regression (perhaps in PR #862?) or if we just didn't have sufficient unit test coverage initially to check all cases.

In the main branch we currently have a test:

    assertValid(
        nc ->
            new DefaultFieldValidator(CountryCode.forStringOrUnknown("ZZ"))
                .validatePhoneNumber("+1 (650) 253-0000", CELL_CONTEXT, nc));

...but this test doesn't cover this case and it still passes on the main branch. Evidently the phone number validation library considers +1 (650) 253-0000 a valid phone number even when no valid country code is provided (I'm assuming because it's an international format).

However, the phone number validation library does consider other formats (e.g., common US format 813-254-4278) invalid without a country code.

I've added another assertion to check an unknown country code with the US format, and this assertation fails on the current master branch but passes on this PR.

    assertValid(
            nc ->
                    new DefaultFieldValidator(CountryCode.forStringOrUnknown("ZZ"))
                            .validatePhoneNumber("813-254-4278", CELL_CONTEXT, nc));

Expected behavior:

When country code is not provided at the command-line, phone number validation should be skipped.

---

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the unit tests with gradle test to make sure you didn't break anything
• Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
• Linked all relevant issues

[github-actions]

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

[aababilov]

Thank you!

[aababilov]

Please merge the last two lines and put a full stop at the end.

[barbeau]

Thanks for catching that! Not sure why the code formatter split the lines, but it's fixed now with the period too in 5223228.

[aababilov]

Please put a full stop at the end of comments. They must be complete sentences.

[barbeau]

Done in 5223228.

[isabelle-dr]

Thank you @barbeau!

We can then cancel PR #1061 when this is merged, problem solved 🎉

[lionel-nj]

Thanks for working on that @barbeau, it seems that some unit test failed though: https://github.com/MobilityData/gtfs-validator/runs/4170664366?check_suite_focus=true.

[barbeau]

@lionel-nj Whoops, I accidentally restored that test in my original commit when testing locally - it should be removed because we don't want to run validation on unknown country codes. I removed it in 381683c so it should pass now.

[lionel-nj]

After analyzing the validation reports produced by https://github.com/MobilityData/gtfs-validator/actions/runs/1446146385 - I confirm that no more InvalidPhoneNumberNotice is triggered. Thanks for fixing #1058 @barbeau!