-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: SystemStubs instead of SystemLambda #1092
test: SystemStubs instead of SystemLambda #1092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests run fine for me now. Aside: CLA bot seems like it got confused. I haven't un-signed the CLA or anything. |
We had to reconfigure the CLA assistant, this is normal. Could you sign the CLA again? |
OK |
@ed-g We have configured the repository so that a branch is up to date with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for this contribution @ed-g!
@@ -23,6 +23,7 @@ dependencies { | |||
implementation 'com.beust:jcommander:1.48' | |||
implementation 'com.google.code.gson:gson:2.8.6' | |||
implementation 'com.github.stefanbirkner:system-lambda:1.2.0' | |||
implementation 'uk.org.webcompere:system-stubs-core:2.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for coming in late here, but if this is just used in tests then I believe this should be testImplementation
similar to the below line. Otherwise we're going to be packaging this dependency with the release JAR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like latest version is 2.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for coming in late here, but if this is just used in tests then I believe this should be
testImplementation
similar to the below line. Otherwise we're going to be packaging this dependency with the release JAR.
I was not aware of this distinction. I will know for next time :) Everything is fixed in #1140
@@ -23,6 +23,7 @@ dependencies { | |||
implementation 'com.beust:jcommander:1.48' | |||
implementation 'com.google.code.gson:gson:2.8.6' | |||
implementation 'com.github.stefanbirkner:system-lambda:1.2.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can dependency on 'com.github.stefanbirkner:system-lambda:1.2.0'
be removed now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I didn't notice. Good catch.
Summary:
system stubs for #1086 (comment)