Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix typo for Missing RequiredFileNotice #1130

Merged
merged 1 commit into from
May 3, 2022

Conversation

isabelle-dr
Copy link
Contributor

Summary:
The table in NOTICES.md was showing more values than what the notice produced.

Expected behaviour:
Only the file name is produced by this notice, as seen in the MissingRequiredFileNotice.java file:

public class MissingRequiredFileNotice extends ValidationNotice {
  private final String filename;

  public MissingRequiredFileNotice(String filename) {
    super(SeverityLevel.ERROR);
    this.filename = filename;
  }
}

Please make sure these boxes are checked before submitting your pull request - thanks!

- [ ] Run the unit tests with gradle test to make sure you didn't break anything

  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@isabelle-dr isabelle-dr added the documentation Anything related to our documentation label Apr 29, 2022
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @isabelle-dr

@maximearmstrong maximearmstrong merged commit 25c909d into master May 3, 2022
@maximearmstrong maximearmstrong deleted the isabelle-dr-patch-NOTICES.md branch May 3, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants