-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an icon for the GUI application #1179
feat: Add an icon for the GUI application #1179
Conversation
These icons are not final, but meant as a test of the packaging platform.
…s-validator into issue/1162/icons
…s-validator into issue/1162/icons
|
Note that I accidentally had one commit in this PR that used my [email protected] address (as opposed to [email protected]), so CLA Assistant is going to complain. Sorry I missed that! |
Thank you so much @bdferris! LGTM. If you're not planning other additions, I can merge & publish the release (🎉) |
I've got one more tweak for the in-app icon. Give me five minutes, almost there. |
I'm surprised the |
@isabelle-dr it looks like it ran to me? https://github.com/MobilityData/gtfs-validator/actions/runs/2436559851 |
Oh okay, it is |
@isabelle-dr the CLA Assistant is still blocking this, such that I don't think I can submit on my own. Do you have the power to override? |
I do :) |
Yep! Submit away!
…On Fri, Jun 3, 2022, 13:24 isabelle-dr ***@***.***> wrote:
I do :)
Are you done on your end?
—
Reply to this email directly, view it on GitHub
<#1179 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEZ7ERGMD67ZKDI4JFZ67TVNJSXDANCNFSM5XZYBB6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Summary:
Replaces the default Java icon used for the packaged application.
Closes #1162
gradle test
to make sure you didn't break anything