-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 878: require agency_id when more than one agency, warn when only one #1318
fix 878: require agency_id when more than one agency, warn when only one #1318
Conversation
See my latest comment here in case that helps :) |
@isabelle-dr I think this is ready for review. I've also commented on #1315 where I think there may be some redundancy with the |
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidator.java
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidator.java
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidatorTest.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/RouteAgencyIdValidatorTest.java
Show resolved
Hide resolved
Sounds good, I will have a look shortly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @briandonahue for working on this!
…one (MobilityData#1318) * fix: require agency_id when more than one agency, warn when only one * Remove custom error, use MissingRecommendedField * Add agency_id validation for fare_attributes.txt, make consistent with routes.txt validator * formatting * Update references for missing_recommended_field warning * Account for possibility of 0 agencies * add no notice test cases for routes.txt * inline method * add no notice test cases for fare_attributes.txt --------- Co-authored-by: Kevin Clough <[email protected]>
Summary:
Closes #878
agency_id
if more than one agency inagency.txt
agency.txt
butagency_id
is not providedagency_id
is missing inroutes.txt
and a single agency is defined inagency.txt
with noagency_id
agency_id
is missing inroutes.txt
but is included for single agency inagency.txt
Expected behavior:
N/A
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything